Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1b5438e

Browse files
committed
Fix incorrect initialization of BackendActivityBuffer.
Since commit c8e8b5a, this has been zeroed out using the wrong length. In practice the length would always be too small, leading to not zeroing the whole buffer rather than clobbering additional memory; and that's pretty harmless, both because shmem would likely start out as zeroes and because we'd reinitialize any given entry before use. Still, it's bogus, so fix it. Reported by Petru-Florin Mihancea (bug #15312) Discussion: https://postgr.es/m/153363913073.1303.6518849192351268091@wrigleys.postgresql.org
1 parent 187331f commit 1b5438e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/postmaster/pgstat.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2695,7 +2695,7 @@ CreateSharedBackendStatus(void)
26952695

26962696
if (!found)
26972697
{
2698-
MemSet(BackendActivityBuffer, 0, size);
2698+
MemSet(BackendActivityBuffer, 0, BackendActivityBufferSize);
26992699

27002700
/* Initialize st_activity pointers. */
27012701
buffer = BackendActivityBuffer;

0 commit comments

Comments
 (0)