Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1fa4fee

Browse files
committed
add some comments and fixme's
1 parent 2853e6a commit 1fa4fee

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

multimaster.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2370,7 +2370,7 @@ static void MtmInitialize()
23702370
Mtm->nLiveNodes = 0; //MtmNodes;
23712371
Mtm->nAllNodes = MtmNodes;
23722372
Mtm->disabledNodeMask = 7; //XXXX
2373-
Mtm->clique = 7; // XXXX
2373+
Mtm->clique = 7; // XXXX ! should be inverted !
23742374
Mtm->stalledNodeMask = 0;
23752375
Mtm->stoppedNodeMask = 0;
23762376
Mtm->deadNodeMask = 0;

pglogical_receiver.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,7 @@ pglogical_receiver_main(Datum main_arg)
366366
}
367367
if (n_deleted_slots == Mtm->nAllNodes - 1)
368368
{
369-
elog(WARNING, "All neighbour nopes have no replication slot for us. Exiting.");
370-
kill(PostmasterPid, SIGTERM);
369+
elog(FATAL, "All neighbour nopes have no replication slot for us. Exiting.");
371370
}
372371
proc_exit(1);
373372
}

state.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ MtmCheckState(void)
143143

144144

145145
void
146-
MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev)
146+
MtmStateProcessNeighborEvent(int node_id, MtmNeighborEvent ev) // XXXX camelcase node_id
147147
{
148148
MTM_LOG1("[STATE] Node %i: %s", node_id, MtmNeighborEventMnem[ev]);
149149

@@ -402,7 +402,7 @@ MtmRefreshClusterStatus()
402402

403403
if (newClique != trivialClique)
404404
{
405-
MTM_LOG1("[STATE] NONTRIVIAL CLIQUE!");
405+
MTM_LOG1("[STATE] NONTRIVIAL CLIQUE! (trivial: %s)", maskToString(trivialClique, Mtm->nAllNodes)); // XXXX some false-positives, fixme
406406
}
407407

408408
/*

0 commit comments

Comments
 (0)