Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 20e11f2

Browse files
committed
From: Darren King <darrenk@insightdist.com>
I have always been under the impression that NULL is not equal to NULL and that NULL is not equal to anything else either. If this is the case, then this patch is correct. If NULL _is_ equal to NULL, then I think there are other problems in the Group By logic.
1 parent d57753e commit 20e11f2

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/backend/executor/nodeGroup.c

+6-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* columns. (ie. tuples from the same group are consecutive)
1414
*
1515
* IDENTIFICATION
16-
* $Header: /cvsroot/pgsql/src/backend/executor/nodeGroup.c,v 1.11 1997/10/27 12:00:43 vadim Exp $
16+
* $Header: /cvsroot/pgsql/src/backend/executor/nodeGroup.c,v 1.12 1998/01/26 00:21:02 scrappy Exp $
1717
*
1818
*-------------------------------------------------------------------------
1919
*/
@@ -415,8 +415,11 @@ sameGroup(TupleTableSlot *oldslot,
415415

416416
if (isNull1 == isNull2)
417417
{
418-
if (isNull1) /* both are null, they are equal */
419-
continue;
418+
/* both are null, they are _not_ equal since
419+
* NULL is not equal to NULL (or anything).
420+
* -- 25 Jan 1998 -- darrenk */
421+
if (isNull1)
422+
return FALSE;
420423

421424
val1 = fmgr(typoutput, attr1,
422425
gettypelem(tupdesc->attrs[att - 1]->atttypid));

0 commit comments

Comments
 (0)