Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 2b2a507

Browse files
tglsfdctglsfdc
committed
Fix all known problems with pg_dump's handling of serial sequences
by abandoning the idea that it should say SERIAL in the dump. Instead, dump serial sequences and column defaults just like regular ones. Add a new backend command ALTER SEQUENCE OWNED BY to let pg_dump recreate the sequence-to-column dependency that was formerly created "behind the scenes" by SERIAL. This restores SERIAL to being truly "just a macro" consisting of component operations that can be stated explicitly in SQL. Furthermore, the new command allows sequence ownership to be reassigned, so that old mistakes can be cleaned up. Also, downgrade the OWNED-BY dependency from INTERNAL to AUTO, since there is no longer any very compelling argument why the sequence couldn't be dropped while keeping the column. (This forces initdb, to be sure the right kinds of dependencies are in there.) Along the way, add checks to prevent ALTER OWNER or SET SCHEMA on an owned sequence; you can now only do this indirectly by changing the owning table's owner or schema. This is an oversight in previous releases, but probably not worth back-patching.
1 parent df18c51 commit 2b2a507

29 files changed

+590
-356
lines changed

‎doc/src/sgml/datatype.sgml

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- $PostgreSQL: pgsql/doc/src/sgml/datatype.sgml,v 1.169 2006/07/06 01:46:37 momjian Exp $ -->
1+
<!-- $PostgreSQL: pgsql/doc/src/sgml/datatype.sgml,v 1.170 2006/08/21 00:57:23 tgl Exp $ -->
22

33
<chapter id="datatype">
44
<title id="datatype-title">Data Types</title>
@@ -705,17 +705,19 @@ CREATE TABLE <replaceable class="parameter">tablename</replaceable> (
705705
<programlisting>
706706
CREATE SEQUENCE <replaceable class="parameter">tablename</replaceable>_<replaceable class="parameter">colname</replaceable>_seq;
707707
CREATE TABLE <replaceable class="parameter">tablename</replaceable> (
708-
<replaceable class="parameter">colname</replaceable> integer DEFAULT nextval('<replaceable class="parameter">tablename</replaceable>_<replaceable class="parameter">colname</replaceable>_seq') NOT NULL
708+
<replaceable class="parameter">colname</replaceable> integer NOT NULL DEFAULT nextval('<replaceable class="parameter">tablename</replaceable>_<replaceable class="parameter">colname</replaceable>_seq')
709709
);
710+
ALTER SEQUENCE <replaceable class="parameter">tablename</replaceable>_<replaceable class="parameter">colname</replaceable>_seq OWNED BY <replaceable class="parameter">tablename</replaceable>.<replaceable class="parameter">colname</replaceable>;
710711
</programlisting>
711712

712713
Thus, we have created an integer column and arranged for its default
713714
values to be assigned from a sequence generator. A <literal>NOT NULL</>
714715
constraint is applied to ensure that a null value cannot be explicitly
715-
inserted, either. In most cases you would also want to attach a
716+
inserted, either. (In most cases you would also want to attach a
716717
<literal>UNIQUE</> or <literal>PRIMARY KEY</> constraint to prevent
717718
duplicate values from being inserted by accident, but this is
718-
not automatic.
719+
not automatic.) Lastly, the sequence is marked as <quote>owned by</>
720+
the column, so that it will be dropped if the column or table is dropped.
719721
</para>
720722

721723
<note>
@@ -749,20 +751,9 @@ CREATE TABLE <replaceable class="parameter">tablename</replaceable> (
749751

750752
<para>
751753
The sequence created for a <type>serial</type> column is
752-
automatically dropped when the owning column is dropped, and
753-
cannot be dropped otherwise. (This was not true in
754-
<productname>PostgreSQL</productname> releases before 7.3. Note
755-
that this automatic drop linkage will not occur for a sequence
756-
created by reloading a dump from a pre-7.3 database; the dump
757-
file does not contain the information needed to establish the
758-
dependency link.) Furthermore, this dependency between sequence
759-
and column is made only for the <type>serial</> column itself. If
760-
any other columns reference the sequence (perhaps by manually
761-
calling the <function>nextval</> function), they will be broken
762-
if the sequence is removed. Using a <type>serial</> column's sequence
763-
in such a fashion is considered bad form; if you wish to feed several
764-
columns from the same sequence generator, create the sequence as an
765-
independent object.
754+
automatically dropped when the owning column is dropped.
755+
You can drop the sequence without dropping the column, but this
756+
will force removal of the column default expression.
766757
</para>
767758
</sect2>
768759
</sect1>

‎doc/src/sgml/func.sgml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.330 2006/08/17 23:04:03 tgl Exp $ -->
1+
<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.331 2006/08/21 00:57:23 tgl Exp $ -->
22

33
<chapter id="functions">
44
<title>Functions and Operators</title>
@@ -9863,10 +9863,14 @@ SELECT pg_type_is_visible('myschema.widget'::regtype);
98639863

98649864
<para>
98659865
<function>pg_get_serial_sequence</function> fetches the name of the
9866-
sequence associated with a <type>serial</> or <type>bigserial</>
9867-
column. The name is suitably formatted for passing to the sequence
9868-
functions (see <xref linkend="functions-sequence">). NULL is
9869-
returned if the column does not have an associated sequence.
9866+
sequence associated with a column, or NULL if there is no sequence
9867+
associated with the column. The result is suitably formatted for passing
9868+
to the sequence functions (see <xref linkend="functions-sequence">).
9869+
This association can be modified or removed with <command>ALTER SEQUENCE
9870+
OWNED BY</>. (The function probably should have been called
9871+
<function>pg_get_owned_sequence</function>; its name reflects the fact
9872+
that it's typically used with <type>serial</> or <type>bigserial</>
9873+
columns.)
98709874
</para>
98719875

98729876
<para>

‎doc/src/sgml/ref/alter_sequence.sgml

Lines changed: 39 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_sequence.sgml,v 1.13 2005/11/01 21:09:50 tgl Exp $
2+
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_sequence.sgml,v 1.14 2006/08/21 00:57:24 tgl Exp $
33
PostgreSQL documentation
44
-->
55

@@ -27,6 +27,7 @@ PostgreSQL documentation
2727
ALTER SEQUENCE <replaceable class="parameter">name</replaceable> [ INCREMENT [ BY ] <replaceable class="parameter">increment</replaceable> ]
2828
[ MINVALUE <replaceable class="parameter">minvalue</replaceable> | NO MINVALUE ] [ MAXVALUE <replaceable class="parameter">maxvalue</replaceable> | NO MAXVALUE ]
2929
[ RESTART [ WITH ] <replaceable class="parameter">start</replaceable> ] [ CACHE <replaceable class="parameter">cache</replaceable> ] [ [ NO ] CYCLE ]
30+
[ OWNED BY { <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable> | NONE } ]
3031
ALTER SEQUENCE <replaceable class="parameter">name</replaceable> SET SCHEMA <replaceable class="parameter">new_schema</replaceable>
3132
</synopsis>
3233
</refsynopsisdiv>
@@ -163,6 +164,24 @@ ALTER SEQUENCE <replaceable class="parameter">name</replaceable> SET SCHEMA <rep
163164
</listitem>
164165
</varlistentry>
165166

167+
<varlistentry>
168+
<term><literal>OWNED BY</literal> <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable></term>
169+
<term><literal>OWNED BY NONE</literal></term>
170+
<listitem>
171+
<para>
172+
The <literal>OWNED BY</literal> option causes the sequence to be
173+
associated with a specific table column, such that if that column
174+
(or its whole table) is dropped, the sequence will be automatically
175+
dropped as well. If specified, this association replaces any
176+
previously specified association for the sequence. The specified
177+
table must have the same owner and be in the same schema as the
178+
sequence.
179+
Specifying <literal>OWNED BY NONE</literal> removes any existing
180+
association, making the sequence <quote>free-standing</>.
181+
</para>
182+
</listitem>
183+
</varlistentry>
184+
166185
<varlistentry>
167186
<term><replaceable class="parameter">new_schema</replaceable></term>
168187
<listitem>
@@ -191,16 +210,20 @@ ALTER SEQUENCE serial RESTART WITH 105;
191210

192211
<para>
193212
To avoid blocking of concurrent transactions that obtain numbers from the
194-
same sequence, <command>ALTER SEQUENCE</command> is never rolled back;
195-
the changes take effect immediately and are not reversible.
213+
same sequence, <command>ALTER SEQUENCE</command>'s effects on the sequence
214+
generation parameters are never rolled back;
215+
those changes take effect immediately and are not reversible. However,
216+
the <literal>OWNED BY</> and <literal>SET SCHEMA</> clauses are ordinary
217+
catalog updates and can be rolled back.
196218
</para>
197219

198220
<para>
199221
<command>ALTER SEQUENCE</command> will not immediately affect
200222
<function>nextval</> results in backends,
201223
other than the current one, that have preallocated (cached) sequence
202224
values. They will use up all cached values prior to noticing the changed
203-
sequence parameters. The current backend will be affected immediately.
225+
sequence generation parameters. The current backend will be affected
226+
immediately.
204227
</para>
205228

206229
<para>
@@ -217,10 +240,20 @@ ALTER SEQUENCE serial RESTART WITH 105;
217240
<para>
218241
<command>ALTER SEQUENCE</command> conforms to the <acronym>SQL</acronym>
219242
standard,
220-
except for the <literal>SET SCHEMA</literal> variant, which is a
221-
<productname>PostgreSQL</productname> extension.
243+
except for the <literal>OWNED BY</> and <literal>SET SCHEMA</literal>
244+
clauses, which are <productname>PostgreSQL</productname> extensions.
222245
</para>
223246
</refsect1>
247+
248+
<refsect1>
249+
<title>See Also</title>
250+
251+
<simplelist type="inline">
252+
<member><xref linkend="sql-createsequence" endterm="sql-createsequence-title"></member>
253+
<member><xref linkend="sql-dropsequence" endterm="sql-dropsequence-title"></member>
254+
</simplelist>
255+
</refsect1>
256+
224257
</refentry>
225258

226259
<!-- Keep this comment at the end of the file

‎doc/src/sgml/ref/alter_table.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_table.sgml,v 1.88 2006/08/03 20:57:06 tgl Exp $
2+
$PostgreSQL: pgsql/doc/src/sgml/ref/alter_table.sgml,v 1.89 2006/08/21 00:57:24 tgl Exp $
33
PostgreSQL documentation
44
-->
55

@@ -371,7 +371,7 @@ where <replaceable class="PARAMETER">action</replaceable> is one of:
371371
<listitem>
372372
<para>
373373
This form moves the table into another schema. Associated indexes,
374-
constraints, and SERIAL-column sequences are moved as well.
374+
constraints, and sequences owned by table columns are moved as well.
375375
</para>
376376
</listitem>
377377
</varlistentry>

‎doc/src/sgml/ref/create_sequence.sgml

Lines changed: 47 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$PostgreSQL: pgsql/doc/src/sgml/ref/create_sequence.sgml,v 1.43 2005/11/01 21:09:50 tgl Exp $
2+
$PostgreSQL: pgsql/doc/src/sgml/ref/create_sequence.sgml,v 1.44 2006/08/21 00:57:24 tgl Exp $
33
PostgreSQL documentation
44
-->
55

@@ -23,6 +23,7 @@ PostgreSQL documentation
2323
CREATE [ TEMPORARY | TEMP ] SEQUENCE <replaceable class="parameter">name</replaceable> [ INCREMENT [ BY ] <replaceable class="parameter">increment</replaceable> ]
2424
[ MINVALUE <replaceable class="parameter">minvalue</replaceable> | NO MINVALUE ] [ MAXVALUE <replaceable class="parameter">maxvalue</replaceable> | NO MAXVALUE ]
2525
[ START [ WITH ] <replaceable class="parameter">start</replaceable> ] [ CACHE <replaceable class="parameter">cache</replaceable> ] [ [ NO ] CYCLE ]
26+
[ OWNED BY { <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable> | NONE } ]
2627
</synopsis>
2728
</refsynopsisdiv>
2829

@@ -193,6 +194,22 @@ SELECT * FROM <replaceable>name</replaceable>;
193194
</para>
194195
</listitem>
195196
</varlistentry>
197+
198+
<varlistentry>
199+
<term><literal>OWNED BY</literal> <replaceable class="parameter">table</replaceable>.<replaceable class="parameter">column</replaceable></term>
200+
<term><literal>OWNED BY NONE</literal></term>
201+
<listitem>
202+
<para>
203+
The <literal>OWNED BY</literal> option causes the sequence to be
204+
associated with a specific table column, such that if that column
205+
(or its whole table) is dropped, the sequence will be automatically
206+
dropped as well. The specified table must have the same owner and be in
207+
the same schema as the sequence.
208+
<literal>OWNED BY NONE</literal>, the default, specifies that there
209+
is no such association.
210+
</para>
211+
</listitem>
212+
</varlistentry>
196213
</variablelist>
197214
</refsect1>
198215

@@ -300,11 +317,38 @@ END;
300317
<command>CREATE SEQUENCE</command> conforms to the <acronym>SQL</acronym>
301318
standard, with the following exceptions:
302319
<itemizedlist>
303-
<listitem><para>The standard's <literal>AS &lt;data type&gt;</literal> expression is not supported.</para></listitem>
304-
<listitem><para>Obtaining the next value is done using the <function>nextval()</> function instead of the standard's <command>NEXT VALUE FOR</command> expression.</para></listitem>
320+
<listitem>
321+
<para>
322+
The standard's <literal>AS &lt;data type&gt;</literal> expression is not
323+
supported.
324+
</para>
325+
</listitem>
326+
<listitem>
327+
<para>
328+
Obtaining the next value is done using the <function>nextval()</>
329+
function instead of the standard's <command>NEXT VALUE FOR</command>
330+
expression.
331+
</para>
332+
</listitem>
333+
<listitem>
334+
<para>
335+
The <literal>OWNED BY</> clause is a <productname>PostgreSQL</>
336+
extension.
337+
</para>
338+
</listitem>
305339
</itemizedlist>
306340
</para>
307341
</refsect1>
342+
343+
<refsect1>
344+
<title>See Also</title>
345+
346+
<simplelist type="inline">
347+
<member><xref linkend="sql-altersequence" endterm="sql-altersequence-title"></member>
348+
<member><xref linkend="sql-dropsequence" endterm="sql-dropsequence-title"></member>
349+
</simplelist>
350+
</refsect1>
351+
308352
</refentry>
309353

310354
<!-- Keep this comment at the end of the file

‎doc/src/sgml/ref/drop_sequence.sgml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$PostgreSQL: pgsql/doc/src/sgml/ref/drop_sequence.sgml,v 1.24 2005/11/19 17:39:44 adunstan Exp $
2+
$PostgreSQL: pgsql/doc/src/sgml/ref/drop_sequence.sgml,v 1.25 2006/08/21 00:57:24 tgl Exp $
33
PostgreSQL documentation
44
-->
55

@@ -105,6 +105,7 @@ DROP SEQUENCE serial;
105105

106106
<simplelist type="inline">
107107
<member><xref linkend="sql-createsequence" endterm="sql-createsequence-title"></member>
108+
<member><xref linkend="sql-altersequence" endterm="sql-altersequence-title"></member>
108109
</simplelist>
109110
</refsect1>
110111

0 commit comments

Comments
 (0)