Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 2e54d88

Browse files
Correct comment in Hot Standby nbtree handling
Logic is correct, matching handling of LP_DEAD elsewhere.
1 parent 284c464 commit 2e54d88

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/backend/access/nbtree/nbtxlog.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -714,11 +714,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
714714
UnlockReleaseBuffer(ibuffer);
715715

716716
/*
717-
* XXX If all heap tuples were LP_DEAD then we will be returning
718-
* InvalidTransactionId here, causing conflict for all HS transactions.
719-
* That should happen very rarely (reasoning please?). Also note that
720-
* caller can't tell the difference between this case and the fast path
721-
* exit above. May need to change that in future.
717+
* If all heap tuples were LP_DEAD then we will be returning
718+
* InvalidTransactionId here, which avoids conflicts. This matches
719+
* existing logic which assumes that LP_DEAD tuples must already be
720+
* older than the latestRemovedXid on the cleanup record that
721+
* set them as LP_DEAD, hence must already have generated a conflict.
722722
*/
723723
return latestRemovedXid;
724724
}

0 commit comments

Comments
 (0)