Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 33a332b

Browse files
committed
Relax some asserts in merge join costing code
In the planner, it was possible, given an extreme enough case containing a large number of joins for the number of estimated rows to become infinite. This could cause problems in initial_cost_mergejoin() where we perform some calculations based on those row estimates. A problem case, presented by Onder Kalaci showed an Assert failure from an Assert checking outerstartsel <= outerendsel. In his test case this was effectively NaN <= Inf, which is false. The NaN outerstartsel came from multiplying the infinite outer_path_rows by 0.0. In master, this problem was fixed by a90c950fc, however, that fix was too invasive for the backbranches. Here we just relax the Asserts to allow them to pass. The worst that appears to happen from this is that we show NaN cost values and infinite row estimates in EXPLAIN. add_path() would have had a hard time doing anything useful with such costs, but that does not really matter as if the row estimates were even close to accurate, such plan would not complete this side of the heat death of the universe. Reported-by: Onder Kalaci Backpatch: 9.5 to 13 Discussion: https://postgr.es/m/DM6PR21MB1211FF360183BCA901B27F04D80B0@DM6PR21MB1211.namprd21.prod.outlook.com
1 parent 99ae342 commit 33a332b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/backend/optimizer/path/costsize.c

+6-4
Original file line numberDiff line numberDiff line change
@@ -3040,8 +3040,9 @@ initial_cost_mergejoin(PlannerInfo *root, JoinCostWorkspace *workspace,
30403040
outer_rows = clamp_row_est(outer_path_rows * outerendsel);
30413041
inner_rows = clamp_row_est(inner_path_rows * innerendsel);
30423042

3043-
Assert(outer_skip_rows <= outer_rows);
3044-
Assert(inner_skip_rows <= inner_rows);
3043+
/* skip rows can become NaN when path rows has become infinite */
3044+
Assert(outer_skip_rows <= outer_rows || isnan(outer_skip_rows));
3045+
Assert(inner_skip_rows <= inner_rows || isnan(inner_skip_rows));
30453046

30463047
/*
30473048
* Readjust scan selectivities to account for above rounding. This is
@@ -3053,8 +3054,9 @@ initial_cost_mergejoin(PlannerInfo *root, JoinCostWorkspace *workspace,
30533054
outerendsel = outer_rows / outer_path_rows;
30543055
innerendsel = inner_rows / inner_path_rows;
30553056

3056-
Assert(outerstartsel <= outerendsel);
3057-
Assert(innerstartsel <= innerendsel);
3057+
/* start sel can become NaN when path rows has become infinite */
3058+
Assert(outerstartsel <= outerendsel || isnan(outerstartsel));
3059+
Assert(innerstartsel <= innerendsel || isnan(innerstartsel));
30583060

30593061
/* cost of source data */
30603062

0 commit comments

Comments
 (0)