Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3661400

Browse files
committed
Avoid useless snprintf() call when update_process_title is turned off.
Fujii Masao
1 parent 3e7451a commit 3661400

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/backend/replication/walreceiver.c

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
*
3131
* IDENTIFICATION
32-
* $PostgreSQL: pgsql/src/backend/replication/walreceiver.c,v 1.11 2010/06/03 22:17:32 tgl Exp $
32+
* $PostgreSQL: pgsql/src/backend/replication/walreceiver.c,v 1.12 2010/06/07 15:49:30 tgl Exp $
3333
*
3434
*-------------------------------------------------------------------------
3535
*/
@@ -524,7 +524,6 @@ XLogWalRcvFlush(void)
524524
{
525525
/* use volatile pointer to prevent code rearrangement */
526526
volatile WalRcvData *walrcv = WalRcv;
527-
char activitymsg[50];
528527

529528
issue_xlog_fsync(recvFile, recvId, recvSeg);
530529

@@ -536,8 +535,14 @@ XLogWalRcvFlush(void)
536535
SpinLockRelease(&walrcv->mutex);
537536

538537
/* Report XLOG streaming progress in PS display */
539-
snprintf(activitymsg, sizeof(activitymsg), "streaming %X/%X",
540-
LogstreamResult.Write.xlogid, LogstreamResult.Write.xrecoff);
541-
set_ps_display(activitymsg, false);
538+
if (update_process_title)
539+
{
540+
char activitymsg[50];
541+
542+
snprintf(activitymsg, sizeof(activitymsg), "streaming %X/%X",
543+
LogstreamResult.Write.xlogid,
544+
LogstreamResult.Write.xrecoff);
545+
set_ps_display(activitymsg, false);
546+
}
542547
}
543548
}

0 commit comments

Comments
 (0)