Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3992188

Browse files
committed
Revert "Still further tweaking of deadlock isolation tests."
This reverts commit d03130d. That was dependent on an isolationtester.c change that now proves to be broken; we will need to find another solution.
1 parent 34f13cc commit 3992188

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/test/isolation/expected/deadlock-hard.out

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@ step s3a4: LOCK TABLE a4; <waiting ...>
1515
step s4a5: LOCK TABLE a5; <waiting ...>
1616
step s5a6: LOCK TABLE a6; <waiting ...>
1717
step s6a7: LOCK TABLE a7; <waiting ...>
18-
step s7a8: LOCK TABLE a8; SELECT pg_sleep(5); <waiting ...>
18+
step s7a8: LOCK TABLE a8; <waiting ...>
1919
step s8a1: LOCK TABLE a1; <waiting ...>
2020
step s8a1: <... completed>
21-
ERROR: deadlock detected
22-
step s8c: COMMIT;
2321
step s7a8: <... completed>
24-
pg_sleep
25-
26-
22+
error in steps s8a1 s7a8: ERROR: deadlock detected
23+
step s8c: COMMIT;
2724
step s7c: COMMIT;
2825
step s6a7: <... completed>
2926
step s6c: COMMIT;

src/test/isolation/specs/deadlock-hard.spec

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
# This is a straightforward deadlock scenario. Since it involves more than
22
# two processes, the main lock detector will find the problem and rollback
33
# the session that first discovers it. Set deadlock_timeout in each session
4-
# so that it's predictable which session fails. Also, when s8 fails and
5-
# rolls back, it unblocks s7, so that there is a race as to whether s7a8
6-
# or s8a1 will report first. Add a delay in s7a8 to make that predictable.
4+
# so that it's predictable which session fails.
75

86
setup
97
{
@@ -61,7 +59,7 @@ step "s6c" { COMMIT; }
6159
session "s7"
6260
setup { BEGIN; SET deadlock_timeout = '100s'; }
6361
step "s7a7" { LOCK TABLE a7; }
64-
step "s7a8" { LOCK TABLE a8; SELECT pg_sleep(5); }
62+
step "s7a8" { LOCK TABLE a8; }
6563
step "s7c" { COMMIT; }
6664

6765
session "s8"

0 commit comments

Comments
 (0)