Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4a9ce08

Browse files
committed
Silence another gcc 11 warning.
Per buildfarm and local experimentation, bleeding-edge gcc isn't convinced that the MemSet in reorder_function_arguments() is safe. Shut it up by adding an explicit check that pronargs isn't negative, and by changing MemSet to memset. (It appears that either change is enough to quiet the warning at -O2, but let's do both to be sure.)
1 parent 16f6906 commit 4a9ce08

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/backend/optimizer/util/clauses.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4090,9 +4090,9 @@ reorder_function_arguments(List *args, HeapTuple func_tuple)
40904090
int i;
40914091

40924092
Assert(nargsprovided <= pronargs);
4093-
if (pronargs > FUNC_MAX_ARGS)
4093+
if (pronargs < 0 || pronargs > FUNC_MAX_ARGS)
40944094
elog(ERROR, "too many function arguments");
4095-
MemSet(argarray, 0, pronargs * sizeof(Node *));
4095+
memset(argarray, 0, pronargs * sizeof(Node *));
40964096

40974097
/* Deconstruct the argument list into an array indexed by argnumber */
40984098
i = 0;

0 commit comments

Comments
 (0)