Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4cea603

Browse files
committed
Remove piece of code to zero out minRecoveryPoint when starting crash
recovery. It's zeroed out whenever a checkpoint is written, so the only scenario where the removed code did anything is when you kill archive recovery, remove recovery.conf, and start up the server, so that it goes into crash recovery instead. That's a "don't do that" scenario, but it seems better to not clear minRecoveryPoint but instead update it like we do in archive recovery, which is what will now happen.
1 parent 9a75803 commit 4cea603

File tree

1 file changed

+1
-6
lines changed
  • src/backend/access/transam

1 file changed

+1
-6
lines changed

src/backend/access/transam/xlog.c

+1-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.368 2010/02/08 04:33:53 tgl Exp $
10+
* $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.369 2010/02/08 09:08:51 heikki Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -5656,11 +5656,6 @@ StartupXLOG(void)
56565656
if (XLByteLT(ControlFile->minRecoveryPoint, checkPoint.redo))
56575657
ControlFile->minRecoveryPoint = checkPoint.redo;
56585658
}
5659-
else
5660-
{
5661-
XLogRecPtr InvalidXLogRecPtr = {0, 0};
5662-
ControlFile->minRecoveryPoint = InvalidXLogRecPtr;
5663-
}
56645659
/*
56655660
* set backupStartupPoint if we're starting archive recovery from a
56665661
* base backup

0 commit comments

Comments
 (0)