Crash on NULL again in system table check.

bmomjian · bmomjian · commit 4ed04855b096 · 2000-10-22T05:14:01.000Z
diff --git a/src/backend/catalog/catalog.c b/src/backend/catalog/catalog.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/catalog/catalog.c,v 1.35 2000/10/21 18:41:51 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/catalog/catalog.c,v 1.36 2000/10/22 05:14:01 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -173,7 +173,7 @@ GetDatabasePath(Oid tblNode)
 bool
 IsSystemRelationName(const char *relname)
 {
-	if (relname && relname[0] && relname[1] && relname[2])
+	if (relname[0] && relname[1] && relname[2])
 		return (relname[0] == 'p' &&
 				relname[1] == 'g' &&
 				relname[2] == '_');

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/catalog.c,v 1.35 2000/10/21 18:41:51 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/catalog.c,v 1.36 2000/10/22 05:14:01 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -173,7 +173,7 @@ GetDatabasePath(Oid tblNode)`
`173`	`173`	`bool`
`174`	`174`	`IsSystemRelationName(const char *relname)`
`175`	`175`	`{`
`176`		`- if (relname && relname[0] && relname[1] && relname[2])`
	`176`	`+ if (relname[0] && relname[1] && relname[2])`
`177`	`177`	`return (relname[0] == 'p' &&`
`178`	`178`	`relname[1] == 'g' &&`
`179`	`179`	`relname[2] == '_');`