Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 59f372e

Browse files
committed
Correct code comments for PartitionedRelPruneInfo struct
The comments above the PartitionedRelPruneInfo struct incorrectly document how subplan_map and subpart_map are indexed. This seems to have snuck in on 4e23236. Author: David Rowley <david.rowley@2ndquadrant.com>
1 parent fd5274a commit 59f372e

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/include/nodes/plannodes.h

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,15 +1089,16 @@ typedef struct PartitionPruneInfo
10891089
* PartitionedRelPruneInfo - Details required to allow the executor to prune
10901090
* partitions for a single partitioned table.
10911091
*
1092-
* subplan_map[] and subpart_map[] are indexed by partition index (where
1093-
* zero is the topmost partition, and non-leaf partitions must come before
1094-
* their children). For a leaf partition p, subplan_map[p] contains the
1095-
* zero-based index of the partition's subplan in the parent plan's subplan
1096-
* list; it is -1 if the partition is non-leaf or has been pruned. For a
1097-
* non-leaf partition p, subpart_map[p] contains the zero-based index of
1098-
* that sub-partition's PartitionedRelPruneInfo in the hierarchy's
1099-
* PartitionedRelPruneInfo list; it is -1 if the partition is a leaf or has
1100-
* been pruned. Note that subplan indexes are global across the parent plan
1092+
* subplan_map[] and subpart_map[] are indexed by partition index of the
1093+
* partitioned table referenced by 'rtindex', the partition index being the
1094+
* order that the partitions are defined in the table's PartitionDesc. For a
1095+
* leaf partition p, subplan_map[p] contains the zero-based index of the
1096+
* partition's subplan in the parent plan's subplan list; it is -1 if the
1097+
* partition is non-leaf or has been pruned. For a non-leaf partition p,
1098+
* subpart_map[p] contains the zero-based index of that sub-partition's
1099+
* PartitionedRelPruneInfo in the hierarchy's PartitionedRelPruneInfo list;
1100+
* it is -1 if the partition is a leaf or has been pruned. Note that subplan
1101+
* indexes, as stored in 'subplan_map', are global across the parent plan
11011102
* node, but partition indexes are valid only within a particular hierarchy.
11021103
*/
11031104
typedef struct PartitionedRelPruneInfo

0 commit comments

Comments
 (0)