MSVC: Rebuild spiexceptions.h when out of date.

nmisch · nmisch · commit 64725d7f98a0 · 2017-11-12T18:43:45.000-08:00
Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
@@ -81,6 +81,7 @@ sub DeterminePlatform
 sub IsNewer
 {
 	my ($newfile, $oldfile) = @_;
+	-e $oldfile or warn "source file \"$oldfile\" does not exist";
 	if (   $oldfile ne 'src/tools/msvc/config.pl'
 		&& $oldfile ne 'src/tools/msvc/config_default.pl')
 	{
@@ -327,7 +328,7 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c
 	if ($self->{options}->{python}
 		&& IsNewer(
 			'src/pl/plpython/spiexceptions.h',
-			'src/include/backend/errcodes.txt'))
+			'src/backend/utils/errcodes.txt'))
 	{
 		print "Generating spiexceptions.h...\n";
 		system(

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ sub DeterminePlatform`
`81`	`81`	`sub IsNewer`
`82`	`82`	`{`
`83`	`83`	`my ($newfile, $oldfile) = @_;`
	`84`	`+ -e $oldfile or warn "source file \"$oldfile\" does not exist";`
`84`	`85`	`if ( $oldfile ne 'src/tools/msvc/config.pl'`
`85`	`86`	`&& $oldfile ne 'src/tools/msvc/config_default.pl')`
`86`	`87`	`{`
`@@ -327,7 +328,7 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c`
`327`	`328`	`if ($self->{options}->{python}`
`328`	`329`	`&& IsNewer(`
`329`	`330`	`'src/pl/plpython/spiexceptions.h',`
`330`		`- 'src/include/backend/errcodes.txt'))`
	`331`	`+ 'src/backend/utils/errcodes.txt'))`
`331`	`332`	`{`
`332`	`333`	`print "Generating spiexceptions.h...\n";`
`333`	`334`	`system(`