Fix up crashing symptoms for new serial type by making sure constraint

Thomas G. Lockhart · Thomas G. Lockhart · commit 651e31bb8000 · 1998-08-26T04:20:27.000Z
and index name fields are pstrdup'd (copied) rather than reused.
diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.81 1998/08/25 15:08:12 thomas Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.82 1998/08/26 04:20:27 thomas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -518,7 +518,7 @@ transformCreateStmt(ParseState *pstate, CreateStmt *stmt)
 					}
 
 					sequence = makeNode(CreateSeqStmt);
-					sequence->seqname = constraint->name;
+					sequence->seqname = pstrdup(constraint->name);
 					sequence->options = NIL;
 
 					elog(NOTICE, "CREATE TABLE will create implicit sequence %s for SERIAL column %s.%s",
@@ -528,6 +528,7 @@ transformCreateStmt(ParseState *pstate, CreateStmt *stmt)
 
 					constraint = makeNode(Constraint);
 					constraint->contype = CONSTR_UNIQUE;
+					constraint->name = makeTableName(stmt->relname, column->colname, "key", NULL);
 
 					column->constraints = lappend(column->constraints, constraint);
 				}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.81 1998/08/25 15:08:12 thomas Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.82 1998/08/26 04:20:27 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -518,7 +518,7 @@ transformCreateStmt(ParseState pstate, CreateStmt stmt)`
`518`	`518`	`}`
`519`	`519`
`520`	`520`	`sequence = makeNode(CreateSeqStmt);`
`521`		`- sequence->seqname = constraint->name;`
	`521`	`+ sequence->seqname = pstrdup(constraint->name);`
`522`	`522`	`sequence->options = NIL;`
`523`	`523`
`524`	`524`	`elog(NOTICE, "CREATE TABLE will create implicit sequence %s for SERIAL column %s.%s",`
`@@ -528,6 +528,7 @@ transformCreateStmt(ParseState pstate, CreateStmt stmt)`
`528`	`528`
`529`	`529`	`constraint = makeNode(Constraint);`
`530`	`530`	`constraint->contype = CONSTR_UNIQUE;`
	`531`	`+ constraint->name = makeTableName(stmt->relname, column->colname, "key", NULL);`
`531`	`532`
`532`	`533`	`column->constraints = lappend(column->constraints, constraint);`
`533`	`534`	`}`