Don't use 'int' where you mean 'bool'.

tglsfdc · tglsfdc · commit 67f06327f99b · 2007-01-20T21:40:25.000Z
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -42,7 +42,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.180 2007/01/20 14:45:35 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.181 2007/01/20 21:40:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -121,7 +121,7 @@ static char *expand_fmt_string(const char *fmt, ErrorData *edata);
 static const char *useful_strerror(int errnum);
 static const char *error_severity(int elevel);
 static void append_with_tabs(StringInfo buf, const char *str);
-static int is_log_level_output(int elevel, int log_min_level);
+static bool is_log_level_output(int elevel, int log_min_level);
 
 
 /*
@@ -2052,8 +2052,8 @@ write_stderr(const char *fmt,...)
 	va_end(ap);
 }
 
-
-static int is_log_level_output(int elevel, int log_min_level)
+static bool
+is_log_level_output(int elevel, int log_min_level)
 {
 	/*
 	 *	Complicated because LOG is sorted out-of-order here, between

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@`
`42`	`42`	`*`
`43`	`43`	`*`
`44`	`44`	`* IDENTIFICATION`
`45`		`- * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.180 2007/01/20 14:45:35 momjian Exp $`
	`45`	`+ * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.181 2007/01/20 21:40:25 tgl Exp $`
`46`	`46`	`*`
`47`	`47`	`*-------------------------------------------------------------------------`
`48`	`48`	`*/`
`@@ -121,7 +121,7 @@ static char expand_fmt_string(const char fmt, ErrorData *edata);`
`121`	`121`	`static const char *useful_strerror(int errnum);`
`122`	`122`	`static const char *error_severity(int elevel);`
`123`	`123`	`static void append_with_tabs(StringInfo buf, const char *str);`
`124`		`-static int is_log_level_output(int elevel, int log_min_level);`
	`124`	`+static bool is_log_level_output(int elevel, int log_min_level);`
`125`	`125`
`126`	`126`
`127`	`127`	`/*`
`@@ -2052,8 +2052,8 @@ write_stderr(const char *fmt,...)`
`2052`	`2052`	`va_end(ap);`
`2053`	`2053`	`}`
`2054`	`2054`
`2055`		`-`
`2056`		`-static int is_log_level_output(int elevel, int log_min_level)`
	`2055`	`+static bool`
	`2056`	`+is_log_level_output(int elevel, int log_min_level)`
`2057`	`2057`	`{`
`2058`	`2058`	`/*`
`2059`	`2059`	`* Complicated because LOG is sorted out-of-order here, between`