Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6fc6686

Browse files
committed
Clean up parsing of CREATE TRIGGER's argument list.
Use ColLabel in place of ColId, so that reserved words are accepted as if they were not reserved. Also, remove BCONST and XCONST, which were never documented as allowed. Allowing those exposes to users an implementation detail, namely the format in which the lexer outputs such constants, that seems unwise to expose. No documentation change needed, since this just makes the code act more like you'd expect from reading the CREATE TRIGGER man page. Per complaint from Szymon Guz and subsequent discussion.
1 parent a0c8514 commit 6fc6686

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/backend/parser/gram.y

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4126,9 +4126,7 @@ TriggerFuncArg:
41264126
}
41274127
| FCONST { $$ = makeString($1); }
41284128
| Sconst { $$ = makeString($1); }
4129-
| BCONST { $$ = makeString($1); }
4130-
| XCONST { $$ = makeString($1); }
4131-
| ColId { $$ = makeString($1); }
4129+
| ColLabel { $$ = makeString($1); }
41324130
;
41334131

41344132
OptConstrFromTable:

0 commit comments

Comments
 (0)