Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 78e7279

Browse files
committed
Fix brin "char" test to actually test what it meant to test.
Casting to char, without quotes, does not give the same results as casting to "char". That meant we were not testing the brin "char" paths at all, since we ended up with a text operator not a "char" operator.
1 parent bac9947 commit 78e7279

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/test/regress/expected/brin.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ CREATE TABLE brinopers (colname name, typ text, op text[], value text[],
9696
check (cardinality(op) = cardinality(value)));
9797
INSERT INTO brinopers VALUES
9898
('byteacol', 'bytea', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, BNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAA, ZZZZZZ, ZZZZZZ}'),
99-
('charcol', 'char', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
99+
('charcol', '"char"', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
100100
('namecol', 'name', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, MAAAAA, ZZAAAA, ZZAAAA}'),
101101
('int2col', 'int2', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 999}'),
102102
('int2col', 'int4', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 1999}'),

src/test/regress/sql/brin.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ CREATE TABLE brinopers (colname name, typ text, op text[], value text[],
101101

102102
INSERT INTO brinopers VALUES
103103
('byteacol', 'bytea', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, BNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAABNAAAA, ZZZZZZ, ZZZZZZ}'),
104-
('charcol', 'char', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
104+
('charcol', '"char"', '{>, >=, =, <=, <}', '{A, A, M, Z, Z}'),
105105
('namecol', 'name', '{>, >=, =, <=, <}', '{AAAAAA, AAAAAA, MAAAAA, ZZAAAA, ZZAAAA}'),
106106
('int2col', 'int2', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 999}'),
107107
('int2col', 'int4', '{>, >=, =, <=, <}', '{0, 0, 800, 999, 1999}'),

0 commit comments

Comments
 (0)