Patch for tcl library crash, from Jan Wieck.

bmomjian · bmomjian · commit 9a8fcee342ea · 1997-10-30T17:29:57.000Z
diff --git a/src/interfaces/libpgtcl/pgtclCmds.c b/src/interfaces/libpgtcl/pgtclCmds.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.17 1997/10/30 05:00:56 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.18 1997/10/30 17:29:57 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1331,8 +1331,8 @@ Pg_select(ClientData cData, Tcl_Interp * interp, int argc, char **argv)
 
 		for (column = 0; column < ncols; column++)
 		{
-			strcpy(buffer, PQgetvalue(result, tupno, column));
-			Tcl_SetVar2(interp, argv[3], info[column].cname, buffer, 0);
+			Tcl_SetVar2(interp, argv[3], info[column].cname, 
+				PQgetvalue(result, tupno, column), 0);
 		}
 
 		Tcl_SetVar2(interp, argv[3], ".command", "update", 0);

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.17 1997/10/30 05:00:56 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclCmds.c,v 1.18 1997/10/30 17:29:57 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1331,8 +1331,8 @@ Pg_select(ClientData cData, Tcl_Interp * interp, int argc, char **argv)`
`1331`	`1331`
`1332`	`1332`	`for (column = 0; column < ncols; column++)`
`1333`	`1333`	`{`
`1334`		`- strcpy(buffer, PQgetvalue(result, tupno, column));`
`1335`		`- Tcl_SetVar2(interp, argv[3], info[column].cname, buffer, 0);`
	`1334`	`+ Tcl_SetVar2(interp, argv[3], info[column].cname,`
	`1335`	`+ PQgetvalue(result, tupno, column), 0);`
`1336`	`1336`	`}`
`1337`	`1337`
`1338`	`1338`	`Tcl_SetVar2(interp, argv[3], ".command", "update", 0);`