Trivial code clarity improvement to UpdateStats(); no functional change.

Neil Conway · Neil Conway · commit 9de97c55315d · 2005-06-20T02:07:47.000Z
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.256 2005/05/19 21:35:45 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.257 2005/06/20 02:07:47 neilc Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -1293,10 +1293,10 @@ UpdateStats(Oid relid, double reltuples)
 		}
 	}
 
-	if (!pg_class_scan)
-		heap_freetuple(tuple);
-	else
+	if (in_place_upd)
 		heap_endscan(pg_class_scan);
+	else
+		heap_freetuple(tuple);
 
 	/*
 	 * We shouldn't have to do this, but we do...  Modify the reldesc in

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.256 2005/05/19 21:35:45 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.257 2005/06/20 02:07:47 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -1293,10 +1293,10 @@ UpdateStats(Oid relid, double reltuples)`
`1293`	`1293`	`}`
`1294`	`1294`	`}`
`1295`	`1295`
`1296`		`- if (!pg_class_scan)`
`1297`		`- heap_freetuple(tuple);`
`1298`		`- else`
	`1296`	`+ if (in_place_upd)`
`1299`	`1297`	`heap_endscan(pg_class_scan);`
	`1298`	`+ else`
	`1299`	`+ heap_freetuple(tuple);`
`1300`	`1300`
`1301`	`1301`	`/*`
`1302`	`1302`	`* We shouldn't have to do this, but we do... Modify the reldesc in`