fix bug in MtmNoticeReceiver

kelvich · kelvich · commit a939b57802a6 · 2017-11-13T02:21:36.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -4596,7 +4596,7 @@ MtmNoticeReceiver(void *i, const PGresult *res)
 	if ( (*(int *)i) != MtmNodeId - 1)
 		return;
 
-	stripped_notice = palloc0(len);
+	stripped_notice = palloc0(len + 1);
 
 	if (*notice == 'N')
 	{
@@ -4612,7 +4612,7 @@ MtmNoticeReceiver(void *i, const PGresult *res)
 	}
 	else
 	{
-		stripped_notice = notice;
+		strncpy(stripped_notice, notice, len + 1);
 		MTM_ELOG(WARNING, "%s", stripped_notice);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4596,7 +4596,7 @@ MtmNoticeReceiver(void i, const PGresult res)`
`4596`	`4596`	`if ( ((int )i) != MtmNodeId - 1)`
`4597`	`4597`	`return;`
`4598`	`4598`
`4599`		`- stripped_notice = palloc0(len);`
	`4599`	`+ stripped_notice = palloc0(len + 1);`
`4600`	`4600`
`4601`	`4601`	`if (*notice == 'N')`
`4602`	`4602`	`{`
`@@ -4612,7 +4612,7 @@ MtmNoticeReceiver(void i, const PGresult res)`
`4612`	`4612`	`}`
`4613`	`4613`	`else`
`4614`	`4614`	`{`
`4615`		`- stripped_notice = notice;`
	`4615`	`+ strncpy(stripped_notice, notice, len + 1);`
`4616`	`4616`	`MTM_ELOG(WARNING, "%s", stripped_notice);`
`4617`	`4617`	`}`
`4618`	`4618`