Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit bf22d27

Browse files
committed
Silence warning in non-assert-enabled build
An OID return value was being used only for a (rather pointless) assert. Silence by removing the variable and the assert. Per note from Peter Geoghegan
1 parent 3200b15 commit bf22d27

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/backend/catalog/pg_conversion.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ ConversionCreate(const char *conname, Oid connamespace,
5050
bool nulls[Natts_pg_conversion];
5151
Datum values[Natts_pg_conversion];
5252
NameData cname;
53-
Oid oid;
5453
ObjectAddress myself,
5554
referenced;
5655

@@ -106,8 +105,7 @@ ConversionCreate(const char *conname, Oid connamespace,
106105
tup = heap_form_tuple(tupDesc, values, nulls);
107106

108107
/* insert a new tuple */
109-
oid = simple_heap_insert(rel, tup);
110-
Assert(OidIsValid(oid));
108+
simple_heap_insert(rel, tup);
111109

112110
/* update the index if any */
113111
CatalogUpdateIndexes(rel, tup);

0 commit comments

Comments
 (0)