Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit cb3ce64

Browse files
committed
Cleanup of prototypes. FIx for PQtrace start/stop several times.
1 parent d8972c6 commit cb3ce64

File tree

5 files changed

+34
-64
lines changed

5 files changed

+34
-64
lines changed

src/backend/executor/execMain.c

+7-13
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*
2727
*
2828
* IDENTIFICATION
29-
* $Header: /cvsroot/pgsql/src/backend/executor/execMain.c,v 1.37 1998/01/07 21:02:39 momjian Exp $
29+
* $Header: /cvsroot/pgsql/src/backend/executor/execMain.c,v 1.38 1998/01/14 15:48:09 momjian Exp $
3030
*
3131
*-------------------------------------------------------------------------
3232
*/
@@ -57,28 +57,22 @@
5757

5858

5959
/* decls for local routines only used within this module */
60-
static void
61-
ExecCheckPerms(CmdType operation, int resultRelation, List *rangeTable,
60+
static void ExecCheckPerms(CmdType operation, int resultRelation, List *rangeTable,
6261
Query *parseTree);
63-
static TupleDesc
64-
InitPlan(CmdType operation, Query *parseTree,
62+
static TupleDesc InitPlan(CmdType operation, Query *parseTree,
6563
Plan *plan, EState *estate);
6664
static void EndPlan(Plan *plan, EState *estate);
67-
static TupleTableSlot *
68-
ExecutePlan(EState *estate, Plan *plan,
65+
static TupleTableSlot * ExecutePlan(EState *estate, Plan *plan,
6966
Query *parseTree, CmdType operation,
7067
int numberTuples, ScanDirection direction,
7168
void (*printfunc) ());
7269
static void ExecRetrieve(TupleTableSlot *slot, void (*printfunc) (),
7370
EState *estate);
74-
static void
75-
ExecAppend(TupleTableSlot *slot, ItemPointer tupleid,
71+
static void ExecAppend(TupleTableSlot *slot, ItemPointer tupleid,
7672
EState *estate);
77-
static void
78-
ExecDelete(TupleTableSlot *slot, ItemPointer tupleid,
73+
static void ExecDelete(TupleTableSlot *slot, ItemPointer tupleid,
7974
EState *estate);
80-
static void
81-
ExecReplace(TupleTableSlot *slot, ItemPointer tupleid,
75+
static void ExecReplace(TupleTableSlot *slot, ItemPointer tupleid,
8276
EState *estate, Query *parseTree);
8377

8478
/* end of local decls */

src/backend/optimizer/plan/setrefs.c

+3-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/setrefs.c,v 1.12 1998/01/07 21:04:13 momjian Exp $
10+
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/setrefs.c,v 1.13 1998/01/14 15:48:21 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -36,11 +36,9 @@
3636
static void set_join_tlist_references(Join *join);
3737
static void set_tempscan_tlist_references(SeqScan *tempscan);
3838
static void set_temp_tlist_references(Temp *temp);
39-
static List *
40-
replace_clause_joinvar_refs(Expr *clause,
39+
static List *replace_clause_joinvar_refs(Expr *clause,
4140
List *outer_tlist, List *inner_tlist);
42-
static List *
43-
replace_subclause_joinvar_refs(List *clauses,
41+
static List *replace_subclause_joinvar_refs(List *clauses,
4442
List *outer_tlist, List *inner_tlist);
4543
static Var *replace_joinvar_refs(Var *var, List *outer_tlist, List *inner_tlist);
4644
static List *tlist_temp_references(Oid tempid, List *tlist);

src/backend/utils/cache/relcache.c

+4-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.32 1998/01/07 21:06:13 momjian Exp $
10+
* $Header: /cvsroot/pgsql/src/backend/utils/cache/relcache.c,v 1.33 1998/01/14 15:48:32 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -257,14 +257,11 @@ static HeapTuple ScanPgRelation(RelationBuildDescInfo buildinfo);
257257
static HeapTuple scan_pg_rel_seq(RelationBuildDescInfo buildinfo);
258258
static HeapTuple scan_pg_rel_ind(RelationBuildDescInfo buildinfo);
259259
static Relation AllocateRelationDesc(u_int natts, Form_pg_class relp);
260-
static void
261-
RelationBuildTupleDesc(RelationBuildDescInfo buildinfo,
260+
static void RelationBuildTupleDesc(RelationBuildDescInfo buildinfo,
262261
Relation relation, u_int natts);
263-
static void
264-
build_tupdesc_seq(RelationBuildDescInfo buildinfo,
262+
static void build_tupdesc_seq(RelationBuildDescInfo buildinfo,
265263
Relation relation, u_int natts);
266-
static void
267-
build_tupdesc_ind(RelationBuildDescInfo buildinfo,
264+
static void build_tupdesc_ind(RelationBuildDescInfo buildinfo,
268265
Relation relation, u_int natts);
269266
static Relation RelationBuildDesc(RelationBuildDescInfo buildinfo);
270267
static void IndexedAccessMethodInitialize(Relation relation);

src/include/executor/executor.h

+19-37
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* Copyright (c) 1994, Regents of the University of California
88
*
9-
* $Id: executor.h,v 1.16 1997/11/26 03:54:23 momjian Exp $
9+
* $Id: executor.h,v 1.17 1998/01/14 15:48:43 momjian Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -26,14 +26,12 @@
2626
/*
2727
* prototypes from functions in execAmi.c
2828
*/
29-
extern void
30-
ExecOpenScanR(Oid relOid, int nkeys, ScanKey skeys, bool isindex,
29+
extern void ExecOpenScanR(Oid relOid, int nkeys, ScanKey skeys, bool isindex,
3130
ScanDirection dir, Relation *returnRelation,
3231
Pointer *returnScanDesc);
3332
extern void ExecCloseR(Plan *node);
3433
extern void ExecReScan(Plan *node, ExprContext *exprCtxt, Plan *parent);
35-
extern HeapScanDesc
36-
ExecReScanR(Relation relDesc, HeapScanDesc scanDesc,
34+
extern HeapScanDesc ExecReScanR(Relation relDesc, HeapScanDesc scanDesc,
3735
ScanDirection direction, int nkeys, ScanKey skeys);
3836
extern void ExecMarkPos(Plan *node);
3937
extern void ExecRestrPos(Plan *node);
@@ -43,8 +41,7 @@ extern Relation ExecCreatR(TupleDesc tupType, Oid relationOid);
4341
* prototypes from functions in execJunk.c
4442
*/
4543
extern JunkFilter *ExecInitJunkFilter(List *targetList);
46-
extern bool
47-
ExecGetJunkAttribute(JunkFilter *junkfilter, TupleTableSlot *slot,
44+
extern bool ExecGetJunkAttribute(JunkFilter *junkfilter, TupleTableSlot *slot,
4845
char *attrName, Datum *value, bool *isNull);
4946
extern HeapTuple ExecRemoveJunk(JunkFilter *junkfilter, TupleTableSlot *slot);
5047

@@ -71,20 +68,16 @@ extern void ExecEndNode(Plan *node, Plan *parent);
7168
extern bool execConstByVal;
7269
extern int execConstLen;
7370

74-
extern Datum
75-
ExecExtractResult(TupleTableSlot *slot, AttrNumber attnum,
71+
extern Datum ExecExtractResult(TupleTableSlot *slot, AttrNumber attnum,
7672
bool *isNull);
77-
extern Datum
78-
ExecEvalParam(Param *expression, ExprContext *econtext,
73+
extern Datum ExecEvalParam(Param *expression, ExprContext *econtext,
7974
bool *isNull);
8075

8176
/* stop here */
8277
extern char *GetAttributeByNum(TupleTableSlot *slot, AttrNumber attrno,
8378
bool *isNull);
84-
extern char *
85-
GetAttributeByName(TupleTableSlot *slot, char *attname, bool *isNull);
86-
extern Datum
87-
ExecEvalExpr(Node *expression, ExprContext *econtext, bool *isNull,
79+
extern char *GetAttributeByName(TupleTableSlot *slot, char *attname, bool *isNull);
80+
extern Datum ExecEvalExpr(Node *expression, ExprContext *econtext, bool *isNull,
8881
bool *isDone);
8982
extern bool ExecQual(List *qual, ExprContext *econtext);
9083
extern int ExecTargetListLength(List *targetlist);
@@ -101,22 +94,19 @@ extern TupleTableSlot *ExecScan(Scan *node, TupleTableSlot *(*accessMtd) ());
10194
extern TupleTable ExecCreateTupleTable(int initialSize);
10295
extern void ExecDestroyTupleTable(TupleTable table, bool shouldFree);
10396
extern TupleTableSlot *ExecAllocTableSlot(TupleTable table);
104-
extern TupleTableSlot *
105-
ExecStoreTuple(HeapTuple tuple,
97+
extern TupleTableSlot *ExecStoreTuple(HeapTuple tuple,
10698
TupleTableSlot *slot,
10799
Buffer buffer,
108100
bool shouldFree);
109101
extern TupleTableSlot *ExecClearTuple(TupleTableSlot *slot);
110102
extern bool ExecSetSlotPolicy(TupleTableSlot *slot, bool shouldFree);
111-
extern TupleDesc
112-
ExecSetSlotDescriptor(TupleTableSlot *slot,
103+
extern TupleDesc ExecSetSlotDescriptor(TupleTableSlot *slot,
113104
TupleDesc tupdesc);
114105
extern void ExecSetSlotDescriptorIsNew(TupleTableSlot *slot, bool isNew);
115106
extern void ExecIncrSlotBufferRefcnt(TupleTableSlot *slot);
116107
extern bool TupIsNull(TupleTableSlot *slot);
117108
extern void ExecInitResultTupleSlot(EState *estate, CommonState *commonstate);
118-
extern void
119-
ExecInitScanTupleSlot(EState *estate,
109+
extern void ExecInitScanTupleSlot(EState *estate,
120110
CommonScanState *commonscanstate);
121111
extern void ExecInitMarkedTupleSlot(EState *estate, MergeJoinState *mergestate);
122112
extern void ExecInitOuterTupleSlot(EState *estate, HashJoinState *hashstate);
@@ -128,39 +118,31 @@ extern TupleDesc ExecTypeFromTL(List *targetList);
128118
* prototypes from functions in execTuples.c
129119
*/
130120
extern void ResetTupleCount(void);
131-
extern void
132-
ExecAssignNodeBaseInfo(EState *estate, CommonState *basenode,
121+
extern void ExecAssignNodeBaseInfo(EState *estate, CommonState *basenode,
133122
Plan *parent);
134123
extern void ExecAssignExprContext(EState *estate, CommonState *commonstate);
135-
extern void
136-
ExecAssignResultType(CommonState *commonstate,
124+
extern void ExecAssignResultType(CommonState *commonstate,
137125
TupleDesc tupDesc);
138-
extern void
139-
ExecAssignResultTypeFromOuterPlan(Plan *node,
126+
extern void ExecAssignResultTypeFromOuterPlan(Plan *node,
140127
CommonState *commonstate);
141128
extern void ExecAssignResultTypeFromTL(Plan *node, CommonState *commonstate);
142129
extern TupleDesc ExecGetResultType(CommonState *commonstate);
143130
extern void ExecAssignProjectionInfo(Plan *node, CommonState *commonstate);
144131
extern void ExecFreeProjectionInfo(CommonState *commonstate);
145132
extern TupleDesc ExecGetScanType(CommonScanState *csstate);
146-
extern void
147-
ExecAssignScanType(CommonScanState *csstate,
133+
extern void ExecAssignScanType(CommonScanState *csstate,
148134
TupleDesc tupDesc);
149-
extern void
150-
ExecAssignScanTypeFromOuterPlan(Plan *node,
135+
extern void ExecAssignScanTypeFromOuterPlan(Plan *node,
151136
CommonScanState *csstate);
152137
extern AttributeTupleForm ExecGetTypeInfo(Relation relDesc);
153138

154-
extern void
155-
ExecOpenIndices(Oid resultRelationOid,
139+
extern void ExecOpenIndices(Oid resultRelationOid,
156140
RelationInfo *resultRelationInfo);
157141
extern void ExecCloseIndices(RelationInfo *resultRelationInfo);
158-
extern void
159-
ExecInsertIndexTuples(TupleTableSlot *slot, ItemPointer tupleid,
142+
extern void ExecInsertIndexTuples(TupleTableSlot *slot, ItemPointer tupleid,
160143
EState *estate, bool is_update);
161144
extern void resetVarAttrLenForCreateTable(TupleDesc tupType);
162-
extern void
163-
setVarAttrLenForCreateTable(TupleDesc tupType,
145+
extern void setVarAttrLenForCreateTable(TupleDesc tupType,
164146
List *targetList, List *rangeTable);
165147

166148

src/interfaces/libpq/fe-connect.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.55 1998/01/13 14:57:25 vadim Exp $
10+
* $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.56 1998/01/14 15:48:51 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -1331,7 +1331,6 @@ PQuntrace(PGconn *conn)
13311331
if (conn->Pfdebug)
13321332
{
13331333
fflush(conn->Pfdebug);
1334-
fclose(conn->Pfdebug);
13351334
conn->Pfdebug = NULL;
13361335
}
13371336
}

0 commit comments

Comments
 (0)