Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit d2a51e3

Browse files
committed
Fix function comment for dumpACL()
The comment for dumpACL() got neglected when initacls and initracls were added and the discussion of what 'racls' is wasn't very clear either. Per complaint from Tom.
1 parent 393d47e commit d2a51e3

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

src/bin/pg_dump/pg_dump.c

+14-4
Original file line numberDiff line numberDiff line change
@@ -14435,10 +14435,20 @@ dumpDefaultACL(Archive *fout, DefaultACLInfo *daclinfo)
1443514435
* 'tag' is the tag for the archive entry (typ. unquoted name of object).
1443614436
* 'nspname' is the namespace the object is in (NULL if none).
1443714437
* 'owner' is the owner, NULL if there is no owner (for languages).
14438-
* 'acls' is the string read out of the fooacl system catalog field;
14439-
* it will be parsed here.
14440-
* 'racls' contains any initial ACLs that the object had which have now been
14441-
* revoked by the user, it will also be parsed here.
14438+
* 'acls' contains the ACL string of the object from the appropriate system
14439+
* catalog field; it will be passed to buildACLCommands for building the
14440+
* appropriate GRANT commands.
14441+
* 'racls' contains the ACL string of any initial-but-now-revoked ACLs of the
14442+
* object; it will be passed to buildACLCommands for building the
14443+
* appropriate REVOKE commands.
14444+
* 'initacls' In binary-upgrade mode, ACL string of the object's initial
14445+
* privileges, to be recorded into pg_init_privs
14446+
* 'initracls' In binary-upgrade mode, ACL string of the object's
14447+
* revoked-from-default privileges, to be recorded into pg_init_privs
14448+
*
14449+
* NB: initacls/initracls are needed because extensions can set privileges on
14450+
* an object during the extension's script file and we record those into
14451+
* pg_init_privs as that object's initial privileges.
1444214452
*----------
1444314453
*/
1444414454
static void

0 commit comments

Comments
 (0)