Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit dd1daa0

Browse files
committed
Allow NumericOnly to be "+ FCONST".
The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 4000000000; SET regression=# set random_page_cost = +4000000000; ERROR: syntax error at or near "4000000000" (because 4000000000 is too large to be an ICONST). While there's no actual functional reason to need to write a "+", if we allow it for integers it seems like we should allow it for numerics too. It's been like that forever, so back-patch to all supported branches. Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us
1 parent acab87e commit dd1daa0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/backend/parser/gram.y

+1
Original file line numberDiff line numberDiff line change
@@ -3688,6 +3688,7 @@ opt_by: BY {}
36883688

36893689
NumericOnly:
36903690
FCONST { $$ = makeFloat($1); }
3691+
| '+' FCONST { $$ = makeFloat($2); }
36913692
| '-' FCONST
36923693
{
36933694
$$ = makeFloat($2);

0 commit comments

Comments
 (0)