Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e01e339

Browse files
committed
Improve stability of identity.sql regression test.
I noticed while trying to run the regression tests under a low geqo_threshold that one query on information_schema.columns had unstable (as in, variable from one run to the next) output order. This is pretty unsurprising given the complexity of the underlying plan. Interestingly, of this test's three nigh-identical queries on information_schema.columns, the other two already had ORDER BY clauses guaranteeing stable output. Let's make this one look the same. Back-patch to v10 where this test was added. We've not heard field reports of the test failing, but this experience shows that it can happen when testing under even slightly unusual conditions.
1 parent d2c9ef1 commit e01e339

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/test/regress/expected/identity.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ SELECT * FROM itest6;
335335
102 |
336336
(3 rows)
337337

338-
SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6';
338+
SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6' ORDER BY 1, 2;
339339
table_name | column_name | is_identity | identity_generation
340340
------------+-------------+-------------+---------------------
341341
itest6 | a | YES | BY DEFAULT

src/test/regress/sql/identity.sql

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ INSERT INTO itest6 DEFAULT VALUES;
208208
INSERT INTO itest6 DEFAULT VALUES;
209209
SELECT * FROM itest6;
210210

211-
SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6';
211+
SELECT table_name, column_name, is_identity, identity_generation FROM information_schema.columns WHERE table_name = 'itest6' ORDER BY 1, 2;
212212

213213
ALTER TABLE itest6 ALTER COLUMN b SET INCREMENT BY 2; -- fail, not identity
214214

0 commit comments

Comments
 (0)