needs_toast_table() should ignore dropped columns.

tglsfdc · tglsfdc · commit e19f6bcf64da · 2004-08-31T23:27:05.000Z
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.130 2004/08/31 15:56:39 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.131 2004/08/31 23:27:05 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5760,6 +5760,8 @@ needs_toast_table(Relation rel)
 
 	for (i = 0; i < tupdesc->natts; i++)
 	{
+		if (att[i]->attisdropped)
+			continue;
 		data_length = att_align(data_length, att[i]->attalign);
 		if (att[i]->attlen > 0)
 		{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.130 2004/08/31 15:56:39 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.131 2004/08/31 23:27:05 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -5760,6 +5760,8 @@ needs_toast_table(Relation rel)`
`5760`	`5760`
`5761`	`5761`	`for (i = 0; i < tupdesc->natts; i++)`
`5762`	`5762`	`{`
	`5763`	`+ if (att[i]->attisdropped)`
	`5764`	`+ continue;`
`5763`	`5765`	`data_length = att_align(data_length, att[i]->attalign);`
`5764`	`5766`	`if (att[i]->attlen > 0)`
`5765`	`5767`	`{`