Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e453870

Browse files
committed
Fix broken XML formatting in EXPLAIN output for incremental sorts.
The ExplainCloseGroup arguments for incremental sort usage data didn't match the corresponding ExplainOpenGroup. This only matters for XML-format output, which is probably why we'd not noticed. Daniel Gustafsson, per bug #16683 from Frits Jalvingh Discussion: https://postgr.es/m/16683-8005033324ad34e9@postgresql.org
1 parent 96ed2ae commit e453870

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/backend/commands/explain.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -2830,7 +2830,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
28302830
ExplainPropertyInteger("Peak Sort Space Used", "kB",
28312831
groupInfo->maxMemorySpaceUsed, es);
28322832

2833-
ExplainCloseGroup("Sort Spaces", memoryName.data, true, es);
2833+
ExplainCloseGroup("Sort Space", memoryName.data, true, es);
28342834
}
28352835
if (groupInfo->maxDiskSpaceUsed > 0)
28362836
{
@@ -2847,7 +2847,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
28472847
ExplainPropertyInteger("Peak Sort Space Used", "kB",
28482848
groupInfo->maxDiskSpaceUsed, es);
28492849

2850-
ExplainCloseGroup("Sort Spaces", diskName.data, true, es);
2850+
ExplainCloseGroup("Sort Space", diskName.data, true, es);
28512851
}
28522852

28532853
ExplainCloseGroup("Incremental Sort Groups", groupName.data, true, es);

0 commit comments

Comments
 (0)