Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit f0d6f20

Browse files
committed
Keep pg_stat_statements' query texts in a file, not in shared memory.
This change allows us to eliminate the previous limit on stored query length, and it makes the shared-memory hash table very much smaller, allowing more statements to be tracked. (The default value of pg_stat_statements.max is therefore increased from 1000 to 5000.) In typical scenarios, the hash table can be large enough to hold all the statements commonly issued by an application, so that there is little "churn" in the set of tracked statements, and thus little need to do I/O to the file. To further reduce the need for I/O to the query-texts file, add a way to retrieve all the columns of the pg_stat_statements view except for the query text column. This is probably not of much interest for human use but it could be exploited by programs, which will prefer using the queryid anyway. Ordinarily, we'd need to bump the extension version number for the latter change. But since we already advanced pg_stat_statements' version number from 1.1 to 1.2 in the 9.4 development cycle, it seems all right to just redefine what 1.2 means. Peter Geoghegan, reviewed by Pavel Stehule
1 parent ea9df81 commit f0d6f20

File tree

4 files changed

+929
-191
lines changed

4 files changed

+929
-191
lines changed

contrib/pg_stat_statements/pg_stat_statements--1.1--1.2.sql

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ DROP VIEW pg_stat_statements;
1212
DROP FUNCTION pg_stat_statements();
1313

1414
/* Now redefine */
15-
CREATE FUNCTION pg_stat_statements(
15+
CREATE FUNCTION pg_stat_statements(IN showtext boolean,
1616
OUT userid oid,
1717
OUT dbid oid,
1818
OUT queryid bigint,
@@ -34,10 +34,10 @@ CREATE FUNCTION pg_stat_statements(
3434
OUT blk_write_time float8
3535
)
3636
RETURNS SETOF record
37-
AS 'MODULE_PATHNAME'
38-
LANGUAGE C;
37+
AS 'MODULE_PATHNAME', 'pg_stat_statements_1_2'
38+
LANGUAGE C STRICT VOLATILE;
3939

4040
CREATE VIEW pg_stat_statements AS
41-
SELECT * FROM pg_stat_statements();
41+
SELECT * FROM pg_stat_statements(true);
4242

4343
GRANT SELECT ON pg_stat_statements TO PUBLIC;

contrib/pg_stat_statements/pg_stat_statements--1.2.sql

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ RETURNS void
99
AS 'MODULE_PATHNAME'
1010
LANGUAGE C;
1111

12-
CREATE FUNCTION pg_stat_statements(
12+
CREATE FUNCTION pg_stat_statements(IN showtext boolean,
1313
OUT userid oid,
1414
OUT dbid oid,
1515
OUT queryid bigint,
@@ -31,12 +31,12 @@ CREATE FUNCTION pg_stat_statements(
3131
OUT blk_write_time float8
3232
)
3333
RETURNS SETOF record
34-
AS 'MODULE_PATHNAME'
35-
LANGUAGE C;
34+
AS 'MODULE_PATHNAME', 'pg_stat_statements_1_2'
35+
LANGUAGE C STRICT VOLATILE;
3636

3737
-- Register a view on the function for ease of use.
3838
CREATE VIEW pg_stat_statements AS
39-
SELECT * FROM pg_stat_statements();
39+
SELECT * FROM pg_stat_statements(true);
4040

4141
GRANT SELECT ON pg_stat_statements TO PUBLIC;
4242

0 commit comments

Comments
 (0)