Noticed a small bug in the code. Probably been there for some time. Note

bmomjian · bmomjian · commit f59820134864 · 2001-05-09T19:28:31.000Z
that the original code would consider things like UNIX domain sockets are
regular files.

Gavin Sherry
diff --git a/src/backend/utils/init/findbe.c b/src/backend/utils/init/findbe.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.21 2001/04/21 18:29:29 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.22 2001/05/09 19:28:31 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -74,7 +74,9 @@ ValidateBinary(char *path)
 					path);
 		return -1;
 	}
-	if (!(buf.st_mode & S_IFREG))
+
+	
+	if ((buf.st_mode & S_IFMT) != S_IFREG)
 	{
 		if (DebugLvl > 1)
 			fprintf(stderr, "ValidateBinary: \"%s\" is not a regular file\n",

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.21 2001/04/21 18:29:29 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.22 2001/05/09 19:28:31 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -74,7 +74,9 @@ ValidateBinary(char *path)`
`74`	`74`	`path);`
`75`	`75`	`return -1;`
`76`	`76`	`}`
`77`		`- if (!(buf.st_mode & S_IFREG))`
	`77`	`+`
	`78`	`+`
	`79`	`+ if ((buf.st_mode & S_IFMT) != S_IFREG)`
`78`	`80`	`{`
`79`	`81`	`if (DebugLvl > 1)`
`80`	`82`	`fprintf(stderr, "ValidateBinary: \"%s\" is not a regular file\n",`