Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit fc3297d

Browse files
committed
Make heap_update() set newtup->t_tableOid correctly, for consistency with
the other major heapam.c functions. The only known consequence of this omission is that UPDATE RETURNING failed to return the correct value for "tableoid", as per report from KaiGai Kohei. Back-patch to 8.2. Arguably it's wrong all the way back; but without evidence of visible breakage before RETURNING was added, I'll desist from patching the older branches.
1 parent 04ecc64 commit fc3297d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/backend/access/heap/heapam.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.271 2008/12/03 13:05:22 heikki Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.272 2008/12/16 16:26:08 tgl Exp $
1212
*
1313
*
1414
* INTERFACE ROUTINES
@@ -2604,6 +2604,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,
26042604
HeapTupleHeaderSetXmin(newtup->t_data, xid);
26052605
HeapTupleHeaderSetCmin(newtup->t_data, cid);
26062606
HeapTupleHeaderSetXmax(newtup->t_data, 0); /* for cleanliness */
2607+
newtup->t_tableOid = RelationGetRelid(relation);
26072608

26082609
/*
26092610
* Replace cid with a combo cid if necessary. Note that we already put

0 commit comments

Comments
 (0)