Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 7459484

Browse files
committed
Disable installcheck tests for test_session_hooks
The module requires a preloaded library and the defect can't be cured by a LOAD instruction in the test script. To achieve this we override the installcheck target in the module's Makefile, and exclude ithe module in vcregress.pl. Along the way, revert commit 9989f92.
1 parent 9989f92 commit 7459484

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

src/test/modules/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ SUBDIRS = \
1515
test_pg_dump \
1616
test_rbtree \
1717
test_rls_hooks \
18+
test_session_hooks \
1819
test_shm_mq \
1920
worker_spi
2021

src/test/modules/test_session_hooks/Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@ top_builddir = ../../../..
1919
include $(top_builddir)/src/Makefile.global
2020
include $(top_srcdir)/contrib/contrib-global.mk
2121
endif
22+
23+
# override installcheck - this module requires preloading the test module
24+
installcheck:
25+
@echo Cannot run $@ for test_session_hooks. Run "'make check'" instead.

src/tools/msvc/vcregress.pl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,8 @@ sub modulescheck
383383
my $mstat = 0;
384384
foreach my $module (glob("*"))
385385
{
386+
# test_session_hooks can't run installcheck, so skip it here
387+
next if $module eq 'test_session_hooks';
386388
subdircheck("$topdir/src/test/modules", $module);
387389
my $status = $? >> 8;
388390
$mstat ||= $status;

0 commit comments

Comments
 (0)