Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 94bcdc6

Browse files
author
v.shepard
committed
PBCKP-294 test add expect_error into safe_psql()
1 parent ceb1ee9 commit 94bcdc6

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

testgres/node.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -894,7 +894,7 @@ def psql(self,
894894
return process.returncode, out, err
895895

896896
@method_decorator(positional_args_hack(['dbname', 'query']))
897-
def safe_psql(self, query=None, **kwargs):
897+
def safe_psql(self, query=None, expect_error=False, **kwargs):
898898
"""
899899
Execute a query using psql.
900900
@@ -904,6 +904,8 @@ def safe_psql(self, query=None, **kwargs):
904904
dbname: database name to connect to.
905905
username: database user name.
906906
input: raw input to be passed.
907+
expect_error: if True - fail if we didn't get ret
908+
if False - fail if we got ret
907909
908910
**kwargs are passed to psql().
909911
@@ -916,7 +918,12 @@ def safe_psql(self, query=None, **kwargs):
916918

917919
ret, out, err = self.psql(query=query, **kwargs)
918920
if ret:
919-
raise QueryException((err or b'').decode('utf-8'), query)
921+
if expect_error:
922+
out = (err or b'').decode('utf-8')
923+
else:
924+
raise QueryException((err or b'').decode('utf-8'), query)
925+
elif expect_error:
926+
assert False, f"Exception was expected, but query finished successfully: `{query}` "
920927

921928
return out
922929

0 commit comments

Comments
 (0)