Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1d3682a

Browse files
nathan-bossartCommitfest Bot
authored and
Commitfest Bot
committed
Fix the 006_transfer_modes.pl test.
This test was leaving files like delete_old_cluster.sh in the source directory for VPATH and meson builds. To fix, change the directory to tmp_check before running the test, as was done in commits 15b6d21, 8af917b, and c462b05. Oversight in commit af0d490. Reported-by: Andrew Dunstan <andrew@dunslane.net> (on Discord) Discussion: ???
1 parent 46b4ba5 commit 1d3682a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/bin/pg_upgrade/t/006_transfer_modes.pl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ sub test_mode
102102
$new->clean_node();
103103
}
104104

105+
# In a VPATH build, we'll be started in the source directory, but we want
106+
# to run pg_upgrade in the build directory so that any files generated finish
107+
# in it, like delete_old_cluster.{sh,bat}.
108+
chdir ${PostgreSQL::Test::Utils::tmp_check};
109+
105110
test_mode('--clone');
106111
test_mode('--copy');
107112
test_mode('--copy-file-range');

0 commit comments

Comments
 (0)