Silence complaints about leaks in postmaster.

tglsfdc · Commitfest Bot · commit 296550afcff2 · 2025-05-31T20:09:19.000Z
Valgrind complains about the postmaster's socket-files and lock-files lists being leaked, which we can silence by just not nulling out the static pointers to them. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/285483.1746756246@sss.pgh.pa.us
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
@@ -858,7 +858,6 @@ RemoveSocketFiles(void)
 		(void) unlink(sock_path);
 	}
 	/* Since we're about to exit, no need to reclaim storage */
-	sock_paths = NIL;
 }
 
 
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
@@ -1183,7 +1183,6 @@ UnlinkLockFiles(int status, Datum arg)
 		/* Should we complain if the unlink fails? */
 	}
 	/* Since we're about to exit, no need to reclaim storage */
-	lock_files = NIL;
 
 	/*
 	 * Lock file removal should always be the last externally visible action

Original file line number	Diff line number	Diff line change
`@@ -858,7 +858,6 @@ RemoveSocketFiles(void)`
`858`	`858`	`(void) unlink(sock_path);`
`859`	`859`	`}`
`860`	`860`	`/* Since we're about to exit, no need to reclaim storage */`
`861`		`- sock_paths = NIL;`
`862`	`861`	`}`
`863`	`862`
`864`	`863`
Original file line number	Diff line number	Diff line change
`@@ -1183,7 +1183,6 @@ UnlinkLockFiles(int status, Datum arg)`
`1183`	`1183`	`/* Should we complain if the unlink fails? */`
`1184`	`1184`	`}`
`1185`	`1185`	`/* Since we're about to exit, no need to reclaim storage */`
`1186`		`- lock_files = NIL;`
`1187`	`1186`
`1188`	`1187`	`/*`
`1189`	`1188`	`* Lock file removal should always be the last externally visible action`