Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3fc05db

Browse files
erthalionCommitfest Bot
authored and
Commitfest Bot
committed
Prevent jumbling of every element in ArrayExpr
pg_stat_statements produces multiple entries for queries like SELECT something FROM table WHERE col IN (1, 2, 3, ...) depending on the number of parameters, because every element of ArrayExpr is jumbled. In certain situations it's undesirable, especially if the list becomes too large. Make an array of Const expressions contribute only the first/last elements to the jumble hash. Allow to enable this behavior via the new pg_stat_statements parameter query_id_squash_values with the default value off. Reviewed-by: Zhihong Yu, Sergey Dudoladov, Robert Haas, Tom Lane, Michael Paquier, Sergei Kornilov, Alvaro Herrera, David Geier, Sutou Kouhei, Sami Imseih, Julien Rouhaud Tested-by: Chengxi Sun, Yasuo Honda
1 parent 203c1b4 commit 3fc05db

File tree

15 files changed

+945
-23
lines changed

15 files changed

+945
-23
lines changed

contrib/pg_stat_statements/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ LDFLAGS_SL += $(filter -lm, $(LIBS))
2020
REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/pg_stat_statements/pg_stat_statements.conf
2121
REGRESS = select dml cursors utility level_tracking planning \
2222
user_activity wal entry_timestamp privileges extended \
23-
parallel cleanup oldextversions
23+
parallel cleanup oldextversions squashing
2424
# Disabled because these tests require "shared_preload_libraries=pg_stat_statements",
2525
# which typical installcheck users do not have (e.g. buildfarm clients).
2626
NO_INSTALLCHECK = 1

0 commit comments

Comments
 (0)