Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 7033acb

Browse files
Maxim OrlovCommitfest Bot
Maxim Orlov
authored and
Commitfest Bot
committed
Use 64-bit format output for multixact offsets
Author: Maxim Orlov <orlovmg@gmail.com>
1 parent 03c53a7 commit 7033acb

File tree

6 files changed

+14
-13
lines changed

6 files changed

+14
-13
lines changed

src/backend/access/rmgrdesc/mxactdesc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ multixact_desc(StringInfo buf, XLogReaderState *record)
6565
xl_multixact_create *xlrec = (xl_multixact_create *) rec;
6666
int i;
6767

68-
appendStringInfo(buf, "%u offset %u nmembers %d: ", xlrec->mid,
68+
appendStringInfo(buf, "%u offset %" PRIu64 " nmembers %d: ", xlrec->mid,
6969
xlrec->moff, xlrec->nmembers);
7070
for (i = 0; i < xlrec->nmembers; i++)
7171
out_member(buf, &xlrec->members[i]);
@@ -74,7 +74,7 @@ multixact_desc(StringInfo buf, XLogReaderState *record)
7474
{
7575
xl_multixact_truncate *xlrec = (xl_multixact_truncate *) rec;
7676

77-
appendStringInfo(buf, "offsets [%u, %u), members [%u, %u)",
77+
appendStringInfo(buf, "offsets [%u, %u), members [%" PRIu64 ", %" PRIu64 ")",
7878
xlrec->startTruncOff, xlrec->endTruncOff,
7979
xlrec->startTruncMemb, xlrec->endTruncMemb);
8080
}

src/backend/access/rmgrdesc/xlogdesc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ xlog_desc(StringInfo buf, XLogReaderState *record)
6666
CheckPoint *checkpoint = (CheckPoint *) rec;
6767

6868
appendStringInfo(buf, "redo %X/%X; "
69-
"tli %u; prev tli %u; fpw %s; wal_level %s; xid %u:%u; oid %u; multi %u; offset %u; "
69+
"tli %u; prev tli %u; fpw %s; wal_level %s; xid %u:%u; oid %u; multi %u; offset %" PRIu64 "; "
7070
"oldest xid %u in DB %u; oldest multi %u in DB %u; "
7171
"oldest/newest commit timestamp xid: %u/%u; "
7272
"oldest running xid %u; %s",

src/backend/access/transam/multixact.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1264,7 +1264,8 @@ GetNewMultiXactId(int nmembers, MultiXactOffset *offset)
12641264

12651265
LWLockRelease(MultiXactGenLock);
12661266

1267-
debug_elog4(DEBUG2, "GetNew: returning %u offset %u", result, *offset);
1267+
debug_elog4(DEBUG2, "GetNew: returning %u offset %" PRIu64, result,
1268+
*offset);
12681269
return result;
12691270
}
12701271

@@ -2293,7 +2294,7 @@ MultiXactGetCheckptMulti(bool is_shutdown,
22932294
LWLockRelease(MultiXactGenLock);
22942295

22952296
debug_elog6(DEBUG2,
2296-
"MultiXact: checkpoint is nextMulti %u, nextOffset %u, oldestMulti %u in DB %u",
2297+
"MultiXact: checkpoint is nextMulti %u, nextOffset %" PRIu64 ", oldestMulti %u in DB %u",
22972298
*nextMulti, *nextMultiOffset, *oldestMulti, *oldestMultiDB);
22982299
}
22992300

@@ -2328,7 +2329,7 @@ void
23282329
MultiXactSetNextMXact(MultiXactId nextMulti,
23292330
MultiXactOffset nextMultiOffset)
23302331
{
2331-
debug_elog4(DEBUG2, "MultiXact: setting next multi to %u offset %u",
2332+
debug_elog4(DEBUG2, "MultiXact: setting next multi to %u offset %" PRIu64,
23322333
nextMulti, nextMultiOffset);
23332334
LWLockAcquire(MultiXactGenLock, LW_EXCLUSIVE);
23342335
MultiXactState->nextMXact = nextMulti;
@@ -2519,7 +2520,7 @@ MultiXactAdvanceNextMXact(MultiXactId minMulti,
25192520
}
25202521
if (MultiXactOffsetPrecedes(MultiXactState->nextOffset, minMultiOffset))
25212522
{
2522-
debug_elog3(DEBUG2, "MultiXact: setting next offset to %u",
2523+
debug_elog3(DEBUG2, "MultiXact: setting next offset to %" PRIU64,
25232524
minMultiOffset);
25242525
MultiXactState->nextOffset = minMultiOffset;
25252526
}
@@ -3211,7 +3212,7 @@ TruncateMultiXact(MultiXactId newOldestMulti, Oid newOldestMultiDB)
32113212

32123213
elog(DEBUG1, "performing multixact truncation: "
32133214
"offsets [%u, %u), offsets segments [%" PRIx64 ", %" PRIx64 "), "
3214-
"members [%u, %u), members segments [%" PRIx64 ", %" PRIx64 ")",
3215+
"members [%" PRIu64 ", %" PRIu64 "), members segments [%" PRIx64 ", %" PRIx64 ")",
32153216
oldestMulti, newOldestMulti,
32163217
MultiXactIdToOffsetSegment(oldestMulti),
32173218
MultiXactIdToOffsetSegment(newOldestMulti),
@@ -3471,7 +3472,7 @@ multixact_redo(XLogReaderState *record)
34713472

34723473
elog(DEBUG1, "replaying multixact truncation: "
34733474
"offsets [%u, %u), offsets segments [%" PRIx64 ", %" PRIx64 "), "
3474-
"members [%u, %u), members segments [%" PRIx64 ", %" PRIx64 ")",
3475+
"members [%" PRIu64 ", %" PRIu64 "), members segments [%" PRIx64 ", %" PRIx64 ")",
34753476
xlrec.startTruncOff, xlrec.endTruncOff,
34763477
MultiXactIdToOffsetSegment(xlrec.startTruncOff),
34773478
MultiXactIdToOffsetSegment(xlrec.endTruncOff),

src/backend/access/transam/xlogrecovery.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,7 @@ InitWalRecovery(ControlFileData *ControlFile, bool *wasShutdown_ptr,
884884
U64FromFullTransactionId(checkPoint.nextXid),
885885
checkPoint.nextOid)));
886886
ereport(DEBUG1,
887-
(errmsg_internal("next MultiXactId: %u; next MultiXactOffset: %u",
887+
(errmsg_internal("next MultiXactId: %u; next MultiXactOffset: %" PRIu64,
888888
checkPoint.nextMulti, checkPoint.nextMultiOffset)));
889889
ereport(DEBUG1,
890890
(errmsg_internal("oldest unfrozen transaction ID: %u, in database %u",

src/bin/pg_controldata/pg_controldata.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ main(int argc, char *argv[])
264264
ControlFile->checkPointCopy.nextOid);
265265
printf(_("Latest checkpoint's NextMultiXactId: %u\n"),
266266
ControlFile->checkPointCopy.nextMulti);
267-
printf(_("Latest checkpoint's NextMultiOffset: %u\n"),
267+
printf(_("Latest checkpoint's NextMultiOffset: %" PRIu64 "\n"),
268268
ControlFile->checkPointCopy.nextMultiOffset);
269269
printf(_("Latest checkpoint's oldestXID: %u\n"),
270270
ControlFile->checkPointCopy.oldestXid);

src/bin/pg_resetwal/pg_resetwal.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ PrintControlValues(bool guessed)
759759
ControlFile.checkPointCopy.nextOid);
760760
printf(_("Latest checkpoint's NextMultiXactId: %u\n"),
761761
ControlFile.checkPointCopy.nextMulti);
762-
printf(_("Latest checkpoint's NextMultiOffset: %u\n"),
762+
printf(_("Latest checkpoint's NextMultiOffset: %" PRIu64 "\n"),
763763
ControlFile.checkPointCopy.nextMultiOffset);
764764
printf(_("Latest checkpoint's oldestXID: %u\n"),
765765
ControlFile.checkPointCopy.oldestXid);
@@ -833,7 +833,7 @@ PrintNewControlValues(void)
833833

834834
if (set_mxoff != -1)
835835
{
836-
printf(_("NextMultiOffset: %u\n"),
836+
printf(_("NextMultiOffset: %" PRIu64 "\n"),
837837
ControlFile.checkPointCopy.nextMultiOffset);
838838
}
839839

0 commit comments

Comments
 (0)