Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit e1a943b

Browse files
anarazelCommitfest Bot
authored and
Commitfest Bot
committed
Temporary: Increase BAS_BULKREAD size
Without this we only can execute very little AIO for sequential scans, as there's just not enough buffers in the ring. This isn't the right fix, as just increasing the ring size can have negative performance implications in workloads where the kernel has all the data cached. Author: Reviewed-By: Discussion: https://postgr.es/m/ Backpatch:
1 parent e93050c commit e1a943b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/backend/storage/buffer/freelist.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,12 @@ GetAccessStrategy(BufferAccessStrategyType btype)
555555
return NULL;
556556

557557
case BAS_BULKREAD:
558-
ring_size_kb = 256;
558+
559+
/*
560+
* FIXME: Temporary increase to allow large enough streaming reads
561+
* to actually benefit from AIO. This needs a better solution.
562+
*/
563+
ring_size_kb = 2 * 1024;
559564
break;
560565
case BAS_BULKWRITE:
561566
ring_size_kb = 16 * 1024;

0 commit comments

Comments
 (0)