Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5762~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5762
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 21, 2025

  1. pg_dump: Adjust reltuples from 0 to -1 for dumps on older versions. 

    Before v14, a reltuples value of 0 was ambiguous: it could either
mean the relation is empty, or it could mean that it hadn't yet
been vacuumed or analyzed.  (Commit 3d351d9 taught v14 and newer
to use -1 for the latter case.)  This ambiguity can cause the
planner to choose inefficient plans after restoring to v18 or
newer.  To fix, let's just dump reltuples as -1 in that case.  This
will cause some truly empty tables to be seen as not-yet-processed,
but that seems unlikely to cause too much trouble in practice.

Commit 9879105 fixed a similar problem for vacuumdb by removing
the check for reltuples != 0.  Presumably we could reinstate that
check now, but I've chosen to leave it in place in case reltuples
isn't accurate.  As before, processing some empty tables seems
pretty innocuous.

Author: Hari Krishna Sunder <hari.db.pg@gmail.com>
Discussion: https://postgr.es/m/CAAeiqZ0o2p4SX5_xPcuAbbsmXjg6MJLNuPYSLUjC%3DWh-VeW64A%40mail.gmail.com
    @nathan-bossart
    nathan-bossart authored and Commitfest Bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    ebe73fe View commit details
    Browse the repository at this point in the history

  2. [CF 5762] v3 - translate reltuples from 0 to -1 upon upgrades from <v14 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5762

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/aC36dza2Fw32YMY9@nathan
Author(s):
    Commitfest Bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    ee5c15f View commit details
    Browse the repository at this point in the history
Loading