Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5767~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5767
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on May 21, 2025

  1. In ExecInitModifyTable, don't scribble on the source plan. 

    The code carelessly modified mtstate->ps.plan->targetlist,
which it's not supposed to do.  Fortunately, there's not
really any need to do that because the planner already
set up a perfectly acceptable targetlist for the plan node.
We just need to remove the erroneous assignments and update some
relevant comments.

As it happens, the erroneous assignments caused the targetlist to
point to a different part of the source plan tree, so that there
isn't really a risk of the pointer becoming dangling after executor
termination.  The only visible effect we can find is that EXPLAIN will
show upper references to the ModifyTable's output expressions using
different variables.  Formerly it showed Vars from the first target
relation that survived executor-startup pruning.  Now it always shows
such references using the first relation appearing in the planner
output, independently of what happens during executor pruning.  On the
whole that seems like a good thing.  (We do need a small tweak in
ExplainPreScanNode to ensure that that relation will receive a refname
assignment in set_rtable_names, even if it got pruned at startup.)

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Andres Freund <andres@anarazel.de>
Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/213261.1747611093@sss.pgh.pa.us
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    a404885 View commit details
    Browse the repository at this point in the history

  2. [CF 5767] v1 - Fix violation of principle that plan trees are read-only 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5767

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/1288373.1747843558@sss.pgh.pa.us
Author(s): Tom Lane
    Commitfest Bot committed May 21, 2025
    Configuration menu
    Copy the full SHA
    efc59af View commit details
    Browse the repository at this point in the history
Loading