Clarify that NULL blocks forever in rmw_wait #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says
rmw_wait()
blocks forever if the timeout is negative, but the timeout cannot be negative becausermw_time_t
uses unsigned types.If ros2/rcutils#79 leads to
rclutils_time_point_value_t
using a signed type then it may make sense to propagate signed-ness down tormw
, but either way this documentation should still say it blocks when the time pointer passed in is NULL.CI Linux, only testing
rmw
for any linter tests since this is a documentation change only