rmw serialized to rcutils serialized #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2018
mikaelarguedas
approved these changes
Aug 1, 2018
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| #include "rcutils/allocator.h" | |||
|
|
|||
| #include "rmw/serialized_message.h" | |||
| #include "rmw/types.h" | |||
There was a problem hiding this comment.
Nit: Is this change necessary ?
There was a problem hiding this comment.
I need that for the return values.
|
@Karsten1987 do you still need this branch ? |
dabonnie
pushed a commit
to aws-ros-dev/rmw
that referenced
this pull request
Apr 2, 2019
* move serialized_message to rcutils * delete serialized_message.c * typo Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #144
I let the original test for the serialized message in this package to ensure the typedefs working.
I am happy to remove them if considered as unnecessary.