make writer_guid uint8_t[] instead of int8_t[] for consistency with rmw_gid_t #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address another inconsistency I noticed with with gids in rmw, namely that
rmw_gid_t
is anuint8_t
array andrmw_request_id_t.writer_guid
is aint8_t
array. Changing this would silence somercl
compilation warnings introduced by the service introspection feature (ros2/ros2#1285).Reference:
rmw/rmw/include/rmw/types.h
Lines 356 to 363 in 2259c3f
rmw/rmw/include/rmw/types.h
Lines 620 to 627 in 2259c3f
I'm going to keep this PR as draft until I review the rmw implementations to check if any notable assumptions are made about the signedness of
writer_guid
, but I don't expect it to be an issue.Signed-off-by: Brian Chen brian.chen@openrobotics.org