Merge pull request #328 from vinistock/vs/fix_deconstructed_block_params

Fix WithScope visits for deconstructed block params

Author: kddnewton

lib/syntax_tree/with_scope.rb

@@ -287,7 +287,11 @@ def visit_binary(node)
 
     def add_argument_definitions(list)
       list.each do |param|
-        if param.is_a?(SyntaxTree::MLHSParen)
+        case param
+        when ArgStar
+          value = param.value
+          current_scope.add_local_definition(value, :argument) if value
+        when MLHSParen
           add_argument_definitions(param.contents.parts)
         else
           current_scope.add_local_definition(param, :argument)

test/with_scope_test.rb

@@ -201,6 +201,25 @@ def foo
       assert_argument(collector, "i", definitions: [2], usages: [3])
     end
 
+    def test_collecting_destructured_block_arguments
+      collector = Collector.collect(<<~RUBY)
+        [].each do |(a, *b)|
+        end
+      RUBY
+
+      assert_equal(2, collector.arguments.length)
+      assert_argument(collector, "b", definitions: [1])
+    end
+
+    def test_collecting_anonymous_destructured_block_arguments
+      collector = Collector.collect(<<~RUBY)
+        [].each do |(a, *)|
+        end
+      RUBY
+
+      assert_equal(1, collector.arguments.length)
+    end
+
     def test_collecting_one_line_block_arguments
       collector = Collector.collect(<<~RUBY)
         def foo