Add syscall dup() for unix target
#3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiif
reviewed
Jun 27, 2024
RalfJung
reviewed
Jun 30, 2024
src/shims/unix/fd.rs
Outdated
| match this.machine.fds.dup(old_fd) { | ||
| Some(dup_fd) => { | ||
| if new_fd != old_fd { | ||
| // Close new_fs if it is previously opened. |
There was a problem hiding this comment.
Suggested change
| // Close new_fs if it is previously opened. | |
| // Close new_fs if it is previously opened. | |
| // (If old == new, then `dup_fd` ensure we keep the underlying file description alive.) |
src/shims/unix/fd.rs
Outdated
| // Close new_fs if it is previously opened. | ||
| if let Some(file_descriptor) = this.machine.fds.remove(new_fd) { | ||
| // Ignore close error according to dup2() doc. | ||
| file_descriptor.close(this.machine.communicate()).ok(); |
There was a problem hiding this comment.
Nono, we can never ignore this. This could ignore UB!
You can ignore the Scalar, but the ? that propagates interpreter errors must be present.
There was a problem hiding this comment.
Totally. I didn't distinguish interpreter's error from program's error back then.
src/shims/unix/fd.rs
Outdated
| file_descriptor.close(this.machine.communicate()).ok(); | ||
| } | ||
|
|
||
| this.machine.fds.fds.insert(new_fd, dup_fd); |
There was a problem hiding this comment.
insert returns the old value if any, so instead of calling remove first you can just use that.
|
Looks good, thanks a lot :) |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
dup()anddup2().Fixes #3454