Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 2 commits
- 9 files changed
- 3 contributors
Commits on Sep 10, 2024
-
Use Engine.begin() instead of Engine.connect() to ensure DML/DDL stat…
…ements are committed in migration code (#1129) # Description One of the changes in SQLAlchemy from 1.4.X -> 2.X is that they've removed automatic commits for DDL/DML statements fed into `Connection`s created from `Engine.connect()`. This leads to a few minor bugs in the DB migration code post `0.39.0` release (and the SQLAlchemy 2.X migration in #1127). ## This PR This PR fixes those bugs by using `Connection`s created by `Engine.begin()` instead ### Testing ```bash $ bazel run sematic/db/tests:test_migrate ``` + manual testing in a repo that's using Sematic as a dependency
Commits on Sep 25, 2024
-
Release 0.39.1 with a small bugfix. Tested the bugfix using local server against both an existing mysql DB and a fresh one. Co-authored-by: Josh Bauer <josh@sematic.dev>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.39.0...v0.39.1