Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Make it easy to add your own advice #16

Open
soulgalore opened this issue Feb 22, 2016 · 5 comments
Open

Make it easy to add your own advice #16

soulgalore opened this issue Feb 22, 2016 · 5 comments

Comments

@soulgalore
Copy link
Member

One thing that is missing is that we should make it super easy to add your own advice. It would be cool that you can do it using the CLI standalone but also for other tools that uses the coach (sitespeed.io at the moment).

@soulgalore
Copy link
Member Author

In sitespeed.io we get coaches advice and run them together with timings from Browsertime. We should add an alternative to add your own advice + add your own category.

@sumeetrohra
Copy link
Contributor

@soulgalore can you give me a small example of how you expect it in cli?

@soulgalore
Copy link
Member Author

Well, this isn't super easy, but I think the way it could work would be to point out a new advice following the same structure as today:

--advice dom/performance/newPerfromanceAdvice.js
--advice har/bestpractice/newBestPractice.js

The bad is that you need to know the current structure. but it will make it easier to implement.

What do you feel about it @sumeetrohra or do you have another idea?

@sumeetrohra
Copy link
Contributor

I think something like this would be better
--harAdvice newBestPractice.js
--domAdvice newPerformanceAdvice.js
difficult to implement but a better solution, I guess...

@soulgalore
Copy link
Member Author

That would work but we will miss what category it will use? So we need find a clean way to add that too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants