Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 26fda64

Browse files
committed
Clean up unused method in cookie auth.
1 parent 6085248 commit 26fda64

File tree

9 files changed

+5
-49
lines changed

9 files changed

+5
-49
lines changed

app/ch12-forms/final/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch13-validation/final/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch13-validation/starter/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch14_testing/final/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch14_testing/starter/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch15_deploy/final/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch15_deploy/starter/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

app/ch16_mongodb/final/pypi_org/infrastructure/cookie_auth.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

4+
import bson
55
from flask import Request
66
from flask import Response
77

8-
from pypi_org.infrastructure.num_convert import try_int
8+
from pypi_org.infrastructure.num_convert import try_object_id
99

1010
auth_cookie_name = 'pypi_demo_user'
1111

1212

13-
def set_auth(response: Response, user_id: int):
13+
def set_auth(response: Response, user_id: bson.ObjectId):
1414
hash_val = __hash_text(str(user_id))
1515
val = "{}:{}".format(user_id, hash_val)
1616
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')
@@ -21,11 +21,7 @@ def __hash_text(text: str) -> str:
2121
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2222

2323

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
28-
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
24+
def get_user_id_via_auth_cookie(request: Request) -> Optional[bson.ObjectId]:
2925
if auth_cookie_name not in request.cookies:
3026
return None
3127

@@ -41,7 +37,7 @@ def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
4137
print("Warning: Hash mismatch, invalid cookie value")
4238
return None
4339

44-
return try_int(user_id)
40+
return try_object_id(user_id)
4541

4642

4743
def logout(response: Response):

app/ch16_mongodb/starter/pypi_org/infrastructure/cookie_auth.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import hashlib
2-
from datetime import timedelta
32
from typing import Optional
43

54
from flask import Request
@@ -21,10 +20,6 @@ def __hash_text(text: str) -> str:
2120
return hashlib.sha512(text.encode('utf-8')).hexdigest()
2221

2322

24-
def __add_cookie_callback(_, response: Response, name: str, value: str):
25-
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')
26-
27-
2823
def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
2924
if auth_cookie_name not in request.cookies:
3025
return None

0 commit comments

Comments
 (0)