Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Not detecting unity 6 installs #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bugfinders opened this issue Sep 26, 2024 · 5 comments
Closed

Not detecting unity 6 installs #166

bugfinders opened this issue Sep 26, 2024 · 5 comments

Comments

@bugfinders
Copy link

Unity hub offers 6000.0.20, this offers only upto 18

@unitycoder
Copy link
Owner

yeah, my list comes from the old unity releases list..

will need to switch into their releases API
#136

But the issue is that it only gives 10 releases at a time.. so cannot get full history,
so still need to think how i save the older releases and only request new stuff..

@Legi428
Copy link
Contributor

Legi428 commented Sep 30, 2024

@unitycoder
With the limit parameter you can get up to 25 releases at once. For the rest you can do additional requests using the offset. So something like:
'https://services.api.unity.com/unity/editor/release/v1/releases?limit=25&offset=0'
which will give you a total in the response which you can use to do any additional requests. So when total is 70 you have to do 2 more requests:
'https://services.api.unity.com/unity/editor/release/v1/releases?limit=25&offset=25'
'https://services.api.unity.com/unity/editor/release/v1/releases?limit=25&offset=50'
I'm not sure if it's implemented like that already, but maybe you can do these async and populate the list as it's ready. Or display all rows (70 in my example) and load the additional content only when the users scrolls past the first 25 or so. Limiting how much is downloaded.

@unitycoder
Copy link
Owner

Yup, i'll probably just hardcode the current releases history as include file,
and then fetch for any new releases and save/cache them locally..
(Since it would take too many requests to get full history from scratch)

Lazy loading on demand would be nice (and might work well enough for most users),
but then cannot search or filter versions until enough data is loaded, which could be annoying..

(at least for me, since i often still work with older versions, so i need to find them easily)

@Legi428
Copy link
Contributor

Legi428 commented Sep 30, 2024

Yup, i'll probably just hardcode the current releases history as include file, and then fetch for any new releases and save/cache them locally.. (Since it would take too many requests to get full history from scratch)

Lazy loading on demand would be nice (and might work well enough for most users), but then cannot search or filter versions until enough data is loaded, which could be annoying..

(at least for me, since i often still work with older versions, so i need to find them easily)

I picked up the things you mentioned here and implemented it today. It works really well and still offers a full list of editor to install. I think I might it a bit more robust by using model classes as well as changing the way download Urls are found (they are provided by the api as well so the program now fetches it from there rather than looking for it on the website). I hope the changes are the way you'd like them! :) #167

@unitycoder
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants