refactor(vue): replace getCurrentInstance with utility functions#71
Merged
johnleider merged 4 commits intomasterfrom Jan 5, 2026
Merged
refactor(vue): replace getCurrentInstance with utility functions#71johnleider merged 4 commits intomasterfrom
johnleider merged 4 commits intomasterfrom
Conversation
|
commit: |
AndreyYolkin
commented
Dec 30, 2025
|
|
||
| return toKebabCase(vm?.name?.replace('V0', '') ?? '') | ||
| const name = instanceName() | ||
| if (!name) return '' |
Contributor
Author
There was a problem hiding this comment.
this early return could save a lot of unneeded toKebabCase calls. Tried with 50% undefined names, received 50% ops/sec improvement
Centralize Vue instance checks in new utilities/instance.ts Update composables to use instanceExists and instanceName
95a1e10 to
234e851
Compare
johnleider
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue 3.6 comes wtih a different util for getting a generic component instance, which results in getCurrentInstance being nullish for мapor components (see https://github.com/vuejs/core/releases/tag/v3.6.0-beta.1)
Since the codebase doesn't have a unified way to check existing instance without unneeded warnings on dev (such as getContext) we need to have a wrapper for that
This PR introduced 2 internal methods to get check instance and get its name universally (tested on 3.5.24 and 3.6.0-beta.1)