add event click on wrapper #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used [patch-package](https://github.com/ds300/patch-package) to patch `svelte-avatar@1.1.1` for the project I'm working on.
Very often work for avatar is option to be clickable. With this small addition, I don't need anymore, use my own wrapper around your wrapper. It's also not mandatory, so forwarding the event to it is optional.
Here is the diff that solved my problem:
```diff
diff --git a/node_modules/svelte-avatar/src/Avatar.svelte b/node_modules/svelte-avatar/src/Avatar.svelte
index e057984..96fd965 100644
--- a/node_modules/svelte-avatar/src/Avatar.svelte
+++ b/node_modules/svelte-avatar/src/Avatar.svelte
@@ -71,7 +71,7 @@
}
</style>
-<div
+<div on:click
aria-label={name}
class="wrapper"
style="{style}--borderRadius:{square ? 0 : borderRadius}; --size:{size}; --bgColor:{background};
```
<em>This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).</em>
|
Hi @dawidmachon, |
|
@dawidmachon The main idea was to who uses the avatar can use the own wrapper with all properties needed, do you think that it makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
svelte-avatar@1.1.1for the project I'm working on.Very often work for avatar is option to be clickable. With this small addition, I don't need anymore, use my own wrapper around your wrapper. It's also not mandatory, so forwarding the event to it is optional.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.